bonsai/kiss
3
0
Fork 0
forked from kiss-community/kiss
Code Issues 2 Pull Requests Projects Releases Activity

kiss-size: fix bug when kiss-size runs on big packages

Browse Source 
Previously, if kiss-size was ran on a package that owns a lot of
files, kiss-size would error out. This is because du wasn't
able to handle the number of files provided to it.

This patch solves this issue, by avoiding the generation of the 'files'
variable, and instead piping directly into xargs which then feeds the
files to du.

For an example package that breaks with the previous implementation,
see https://github.com/ehawkvu/kiss-tex/tree/master/texlive/texlive-fontsextra
which installs around 94,000 files.
This commit is contained in:
Ethan 2021-08-04 00:25:06 -05:00
parent 66958b3232
commit b11cd58936
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
contrib/kiss-size
View File

@ -27,14 +27,11 @@ kiss list "${1:-null}" >/dev/null || {
# Filter directories from manifest and leave only files. # Filter directories from manifest and leave only files.
# Directories in the manifest end in a trailing '/'. # Directories in the manifest end in a trailing '/'.
files=$(sed -e "s|^|$KISS_ROOT|" -e 's|.*/$||' \ # Send the file list to 'xargs' to run through 'du',
"$KISS_ROOT/var/db/kiss/installed/$1/manifest") # this prevents du from exiting due to too many arguments
sed -e "s|^|$KISS_ROOT|" -e 's|.*/$||' \
# Send the file list to 'du'. "$KISS_ROOT/var/db/kiss/installed/$1/manifest" \
# This unquoted variable is safe as word splitting is intended | xargs du -sk -- 2>/dev/null |
# and globbing is globally disabled in this script.
# shellcheck disable=2086
du -sk -- $files 2>/dev/null |
# Iterate over each line and convert the byte output to human # Iterate over each line and convert the byte output to human
# readable (MB, KB, GB, etc). # readable (MB, KB, GB, etc).