bonsai/kiss
3
0
Fork 0
forked from kiss-community/kiss
Code Issues 2 Pull Requests Projects Releases Activity

kiss: fix installation of files causing processes to die.

Browse Source 
This modifies pkg_install_files() to do atomic mv on each of the
files. This prevents processes from crashing when the underlying
shared library changes (but the inode stays the same).

Closes #226
This commit is contained in:
Dylan Araps 2021-07-12 01:05:24 +03:00
parent 84989ddd30
commit d3adf7d773
No known key found for this signature in database
GPG Key ID: 13295DAC2CF13B5C
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
kiss
View File

@ -1085,7 +1085,23 @@ pkg_install_files() {
# Skip directories as they're likely symlinks in this case.
# Pure directories in manifests have a suffix of '/'.
[ -d "$_file" ] || test "$1" "$_file" || {
cp -fP "$2/${file#/}" "$_file"
_file_tmp=$2/${file#/}
# Copy the file to a temporary location so that later
# verification (after pkg_remove_files()) is possible.
#
# This duplication only occurs during the first
# invocation of pkg_install_files() - the second call
# will simply do the 'mv' call.
case $1 in -z)
cp -fP "$2/${file#/}" "$2/__f-$pid"
_file_tmp=$2/__f-$pid
esac
# Atomically move the temporary file to the root
# filesystem. The running processes will either get
# the old file or the new one.
mv -f "$_file_tmp" "$_file"
# Skip changing permissions of symlinks. This prevents
# errors when the symlink exists prior to the target.