canary
/
canary-rs
2
1
Fork 0
Code Issues 11 Pull Requests 2 Projects Releases Wiki Activity

Merge crates #17

Merged
mars merged 5 commits from merge-crates into main 2022-11-01 08:17:08 +00:00
Conversation 0 Commits 5 Files Changed 18 +60 -61
mars commented 2022-11-01 08:15:47 +00:00
Owner
Copy Link

I've migrated the protocols and type definitions for crates into the crates themselves, and took advantage of Cargo features to allow other crates to include only the protocols without the code necessary to run the binary that implements that protocol.

  • magpie-types has been moved into magpie and all dependents have been updated
  • the magpie package has been renamed to canary-magpie
  • canary-music-player-protocol has been merged into canary-music-player

Merging of canary-types and canary_script will take a lot more work, so I'll do that in a separate PR, probably along with a full API refactor.

I've migrated the protocols and type definitions for crates into the crates themselves, and took advantage of Cargo features to allow other crates to include only the protocols without the code necessary to run the binary that implements that protocol. - `magpie-types` has been moved into `magpie` and all dependents have been updated - the `magpie` package has been renamed to `canary-magpie` - `canary-music-player-protocol` has been merged into `canary-music-player` Merging of `canary-types` and `canary_script` will take a lot more work, so I'll do that in a separate PR, probably along with a full API refactor.
mars added the
cleanup
consistency
 labels 2022-11-01 08:15:47 +00:00
mars added 4 commits 2022-11-01 08:15:47 +00:00
mars added 1 commit 2022-11-01 08:17:02 +00:00
mars merged commit 18b882f0f3 into main 2022-11-01 08:17:08 +00:00
mars deleted branch merge-crates 2022-11-01 08:17:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
abi change

Breaking ABI change between scripts and host.

  
api change

Changes the interfaces between crates.

  
bug

Unintended behavior.

  
cleanup

Code maintenance, QOL improvements, and refactors.

  
consistency

Keeps all components in sync.

  
feature

To do with new features.

  
performance

Performance improvements.

  
updates docs

Requires a change to the documentation.

No Label
abi change
api change
bug
cleanup
consistency
feature
performance
updates docs
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: canary/canary-rs#17
No description provided.
Delete Branch "merge-crates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?