Refactor runtime #21

New Issue

Closed

opened 2022-11-02 22:02:17 +00:00 by mars · 0 comments

mars commented

2022-11-02 22:02:17 +00:00

Owner

ScriptAbi/ScriptAbiImpl are overcomplicated and mocks should be data-oriented instead of trait-oriented. The generics in WasmtimeRuntime are a pain in the ass for using the API. It is difficult (in theory, because the only backend is Wasmtime right now) to share data between backends without duplicating code. PanelId is clunky to use directly.

Add a backends module for different runtime backends.
Add Backend and Instance traits for backend scripting implementations.
Move all Wasmtime code into backends::wasmtime and implement backend traits.
Add a Runtime struct that uses dynamic trait boxes for the backend.
Update Magpie and the sandbox to use the new API.

`ScriptAbi`/`ScriptAbiImpl` are overcomplicated and mocks should be data-oriented instead of trait-oriented. The generics in `WasmtimeRuntime` are a pain in the ass for using the API. It is difficult (in theory, because the only backend is Wasmtime right now) to share data between backends without duplicating code. `PanelId` is clunky to use directly. 1. Add a `backends` module for different runtime backends. 2. Add `Backend` and `Instance` traits for backend scripting implementations. 3. Move all Wasmtime code into `backends::wasmtime` and implement backend traits. 4. Add a `Runtime` struct that uses dynamic trait boxes for the backend. 5. Update Magpie and the sandbox to use the new API.