Add protocol names #32

New Issue

Closed

opened 2022-11-10 18:04:41 +00:00 by mars · 0 comments

mars commented

2022-11-10 18:04:41 +00:00

Owner

Currently, all Canary scripts will run the same panel implementation regardless of their initialization message. We need to be able to specify which protocol the panel is using during panel binding.

Protocol names will need to be added to:

the BindPanel trait needs to be replaced with a function that takes a new Message argument for the protocol and returns the appropriate PanelImpl
a new String argument to Script::create_panel()
a new String field on Magpie's CreatePanel message
the music player's CreatePanel call (we'll need to come up with a name for the music player protocol)
the SAO UI panel impls (they can ignore the protocol name until we have host protocols defined for whatever UIs the SAO UI implements)

Currently, all Canary scripts will run the same panel implementation regardless of their initialization message. We need to be able to specify which protocol the panel is using during panel binding. Protocol names will need to be added to: - the `BindPanel` trait needs to be replaced with a function that takes a new `Message` argument for the protocol and returns the appropriate `PanelImpl` - a new `String` argument to `Script::create_panel()` - a new `String` field on Magpie's `CreatePanel` message - the music player's `CreatePanel` call (we'll need to come up with a name for the music player protocol) - the SAO UI panel impls (they can ignore the protocol name until we have host protocols defined for whatever UIs the SAO UI implements)