canary
/
canary-rs
2
1
Fork 0
Code Issues 11 Pull Requests 2 Projects Releases Wiki Activity

Refactor colors #6

New Issue
Closed
opened 2022-09-29 16:47:11 +00:00 by mars · 1 comment
mars commented 2022-09-29 16:47:11 +00:00
Owner
Copy Link

As it stands, colors in both the MeshVertex and API arguments are given as four f32s. This is completely unnecessary, and has a negative impact on performance. f32s are slow to convert, and are relatively large, increasing the amount of data to copy.

Instead, colors should always be represented as u32s, represented as RGBA8888.

More resource on HDR formats and different color spaces be needed in the future, but the future is not now.

As it stands, colors in both the `MeshVertex` and API arguments are given as four f32s. This is completely unnecessary, and has a negative impact on performance. f32s are slow to convert, and are relatively large, increasing the amount of data to copy. Instead, colors should always be represented as u32s, represented as RGBA8888. More resource on HDR formats and different color spaces be needed in the future, but the future is not now.
mars self-assigned this 2022-09-29 16:47:15 +00:00
mars added this to the Launch milestone 2022-09-29 16:47:17 +00:00
mars commented 2022-10-20 04:56:44 +00:00
Author
Owner
Copy Link

Completed in 25e60c683b.

Completed in 25e60c683b.
mars closed this issue 2022-10-20 04:56:46 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
android
wgpu-renderer
license-script
force-directed-graph
nes-emulator
Labels
Clear labels   
abi change

Breaking ABI change between scripts and host.

  
api change

Changes the interfaces between crates.

  
bug

Unintended behavior.

  
cleanup

Code maintenance, QOL improvements, and refactors.

  
consistency

Keeps all components in sync.

  
feature

To do with new features.

  
performance

Performance improvements.

  
updates docs

Requires a change to the documentation.

No Label
abi change
api change
bug
cleanup
consistency
feature
performance
updates docs
Milestone
Clear milestone
No items
No Milestone
Launch
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
mars
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: canary/canary-rs#6
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?