kiss-community
/
kiss
mirror of https://codeberg.org/kiss-community/kiss
1
0
Fork 1
Code Issues Wiki

kiss: remove unneeded subshell from pkg_depends

This commit is contained in:
Dylan Araps 2021-07-03 15:08:02 +00:00
parent 65474c56e3
commit 84f1eb7c98
No known key found for this signature in database
GPG Key ID: 13295DAC2CF13B5C
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
kiss
View File

@ -193,15 +193,17 @@ pkg_list() {
[ "$1" ] || { set +f; set -f -- *; }
# Loop over each package and print its name and version.
for pkg do
[ -d "$pkg" ] || {
log "$pkg" "not installed"
for _list_pkg do
[ -d "$_list_pkg" ] || {
log "$_list_pkg" "not installed"
return 1
}
read -r version 2>/dev/null < "$pkg/version" || version=null
printf '%s\n' "$pkg $version"
read -r version 2>/dev/null < "$_list_pkg/version" || version=null
printf '%s\n' "$_list_pkg $version"
done
cd "$OLDPWD"
}
pkg_cache() {
@ -377,7 +379,7 @@ pkg_depends() {
# dependencies are listed first and then the parents in reverse order.
contains "$deps" "$1" || {
# Filter out non-explicit, aleady installed dependencies.
[ "$3" ] && [ -z "$2" ] && (pkg_list "$1" >/dev/null 2>&1) && return
[ "$3" ] && [ -z "$2" ] && pkg_list "$1" >/dev/null 2>&1 && return
# Detect circular dependencies and bail out.
# Looks for multiple repeating patterns of (dep dep_parent) (5 is max).