From a024ef4663aeb8b678978b73c21966ace76b98bf Mon Sep 17 00:00:00 2001 From: Dylan Araps Date: Wed, 14 Jul 2021 21:20:13 +0300 Subject: [PATCH] kiss: simplify run_hook. Remove hardcoded argument count --- kiss | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/kiss b/kiss index daef0b8..c677518 100755 --- a/kiss +++ b/kiss @@ -110,20 +110,13 @@ pkg_owner() { run_hook() { # Run all hooks in KISS_HOOK (a colon separated # list of absolute file paths). - _type=${1:-null} _name=${2:-null} _path=${3:-null} - IFS=: - # Intentional, globbing disabled. - # shellcheck disable=2086 - set -- ${KISS_HOOK:-} + for hook in ${KISS_HOOK:-}; do case $hook in *?*) + "$hook" "$@" || die "$1 hook failed: '$hook'" + esac done unset IFS - - for hook do case $hook in *?*) - "$hook" "$_type" "$_name" "$_path" || - die "$_name" "$_type hook failed: '$hook'" - esac done } run_hook_pkg() {