minecrust
/
hopper
4
0
Fork 2
Code Issues 9 Pull Requests 2 Projects 1 Releases Wiki Activity

Changed out StructOpt for Clap #13

Merged
mars merged 1 commits from UpgradeToClap into main 2022-09-09 10:00:15 +00:00
Conversation 0 Commits 1 Files Changed 4 +60 -85
spookdot commented 2022-09-06 21:18:30 +00:00
Member
Copy Link

This Pull Request is meant to resolve issue #6 and also aid in expanding the CLI more easily in the future
For example StructOpt requires you to implement from_str if you want to use an Enum as possible options for an argument while Clap has a ValueEnum Trait that should do most of that for us
Also it doesn't require "ColoredHelp" be added everywhere
I did test it myself partly but would probably be good for someone else to double check

This Pull Request is meant to resolve issue #6 and also aid in expanding the CLI more easily in the future For example StructOpt requires you to implement from_str if you want to use an Enum as possible options for an argument while Clap has a ValueEnum Trait that should do most of that for us Also it doesn't require "ColoredHelp" be added everywhere I did test it myself partly but would probably be good for someone else to double check
spookdot added 1 commit 2022-09-06 21:18:31 +00:00
mars was assigned by emma 2022-09-06 22:16:39 +00:00
emma added the
enhancement
 label 2022-09-06 22:17:05 +00:00
mars approved these changes 2022-09-09 10:00:08 +00:00
mars left a comment
Owner
Copy Link

Looks good to me. I don't think this needs testing; there aren't many places this could go wrong. We'll fix anything that comes up.

Looks good to me. I don't think this needs testing; there aren't many places this could go wrong. We'll fix anything that comes up.
mars merged commit 6ab97922cb into main 2022-09-09 10:00:15 +00:00
mars deleted branch UpgradeToClap 2022-09-09 10:00:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mars
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
mars
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: minecrust/hopper#13
No description provided.
Delete Branch "UpgradeToClap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?