Inform the user about the url from which will be downloaded. #21

New Issue

Open

opened 2022-12-25 15:26:33 +00:00 by colorspace · 2 comments

colorspace commented

2022-12-25 15:26:33 +00:00

We inform the user about the file that will be created when proceeding, but we don't inform the user from where we download this file.

Maybe we should inform the user about the URL that will be used to download the file, before we do so?

We inform the user about the file that will be created when proceeding, but we don't inform the user from where we download this file. Maybe we should inform the user about the URL that will be used to download the file, before we do so?

emma commented

2022-12-26 22:21:01 +00:00

Owner

╰─[main]# hopper get litematica
Searching with query "litematica"...
 5 AsguhoClient [1.19.3] (220 downloads)
    Simply a really optimized Client with the tools you need to build awesome contraptions, farms and extraordinary looking builds. This modpack include mods such as litematica etc.
 4 Syncmatica [1.19.3] (3143 downloads)
    Syncmatica is a mod which aims to mod into litematica so that schematics and their placements can be easily shared.
 3 GrabcraftLitematic [22w45a] (1551 downloads)
    Import GrabCraft builds into Litematica
 2 Litematica Printer [1.19.2] (937 downloads)
    This fork adds the missing printing functionality for Litematica
 1 Litematica Server Paster [1.19.3] (4034 downloads)
    Let Litematica be able to paste tile entity data of block / entity data in a server
Mods to install (eg: 1 2 3-5): 2
Fetching mod info for Litematica Printer (ID: 3llatzyE)...
fetching version x9MUxjhZ
Fetching mod version x9MUxjhZ...
Download to litematica-printer-1.19.2-2.5.jar? yes

Downloaded https://cdn.modrinth.com/data/3llatzyE/versions/2.5/litematica-printer-1.19.2-2.5.jar to litematica-printer-1.19.2-2.5.jar
  [00:00:00] [##############################################################################] 48.65KB/48.65KB (2.39MB/s, 0s)

hopper get does this, as far as I can see.

``` ╰─[main]# hopper get litematica Searching with query "litematica"... 5 AsguhoClient [1.19.3] (220 downloads) Simply a really optimized Client with the tools you need to build awesome contraptions, farms and extraordinary looking builds. This modpack include mods such as litematica etc. 4 Syncmatica [1.19.3] (3143 downloads) Syncmatica is a mod which aims to mod into litematica so that schematics and their placements can be easily shared. 3 GrabcraftLitematic [22w45a] (1551 downloads) Import GrabCraft builds into Litematica 2 Litematica Printer [1.19.2] (937 downloads) This fork adds the missing printing functionality for Litematica 1 Litematica Server Paster [1.19.3] (4034 downloads) Let Litematica be able to paste tile entity data of block / entity data in a server Mods to install (eg: 1 2 3-5): 2 Fetching mod info for Litematica Printer (ID: 3llatzyE)... fetching version x9MUxjhZ Fetching mod version x9MUxjhZ... Download to litematica-printer-1.19.2-2.5.jar? yes Downloaded https://cdn.modrinth.com/data/3llatzyE/versions/2.5/litematica-printer-1.19.2-2.5.jar to litematica-printer-1.19.2-2.5.jar [00:00:00] [##############################################################################] 48.65KB/48.65KB (2.39MB/s, 0s) ``` `hopper get` does this, as far as I can see.

emma closed this issue

2022-12-26 22:21:01 +00:00

emma added the

invalid

label 2022-12-26 22:21:17 +00:00

colorspace commented

2022-12-28 20:51:24 +00:00

Author

We only show the url
"https://cdn.modrinth.com/data/3llatzyE/versions/2.5/litematica-printer-1.19.2-2.5.jar"
after we agreed to download.

I'm wondering if we should show it before we download.

In case of a malicious file we would only know it is malicious, once it is already on our computer.

We only show the url "https://cdn.modrinth.com/data/3llatzyE/versions/2.5/litematica-printer-1.19.2-2.5.jar" *after* we agreed to download. I'm wondering if we should show it *before* we download. --- In case of a malicious file we would only know it is malicious, once it is already on our computer.

emma reopened this issue

2022-12-30 22:43:51 +00:00

emma added

enhancement

and removed

invalid

labels 2022-12-30 22:44:04 +00:00

emma added this to the Release milestone 2023-03-22 15:07:32 +00:00

emma added reference rewrite

2023-03-23 02:56:20 +00:00

emma referenced a pull request that will close this issue

2023-03-23 04:25:27 +00:00