minecrust
/
hopper
4
0
Fork 2
Code Issues 9 Pull Requests 2 Projects 1 Releases Wiki Activity

ModrinthAPIv2 #9

Merged
mars merged 2 commits from spookdot/hopper:ModrinthAPIv2 into main 2022-08-22 20:31:20 +00:00
Conversation 1 Commits 2 Files Changed 2 +66 -41
spookdot commented 2022-08-20 00:02:43 +00:00
Member
Copy Link

I went through the process that the get command goes through and tried to change all structs and URLs that are affected to their Version 2 state
I tested it against Sodium, and 2 results of the keyword "Tinker" (like Tinkers' Construct), one of them with only 9 downloads, to have some variety. Therefore most Nullable types should also be set as nullable now

I went through the process that the get command goes through and tried to change all structs and URLs that are affected to their Version 2 state I tested it against Sodium, and 2 results of the keyword "Tinker" (like Tinkers' Construct), one of them with only 9 downloads, to have some variety. Therefore most Nullable types should also be set as nullable now
spookdot added 2 commits 2022-08-20 00:02:44 +00:00
mars approved these changes 2022-08-22 20:30:41 +00:00
mars commented 2022-08-22 20:31:15 +00:00
Owner
Copy Link

Very good work! Works on my machine™
Thanks for putting in the extra work to check all the types.

Very good work! Works on my machine™ Thanks for putting in the extra work to check all the types.
mars merged commit 0d8aaaf2c9 into main 2022-08-22 20:31:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mars
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: minecrust/hopper#9
No description provided.
Delete Branch "spookdot/hopper:ModrinthAPIv2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?