tomo/objects
tomo/objects
1
0
Fork 0
Code Issues 4 Pull Requests Packages Projects Releases 27 Wiki Activity

Stop embedding Tomo boxes #7

New Issue
Closed
opened 2024-06-27 12:13:21 -06:00 by sashakoshka · 3 comments
sashakoshka commented 2024-06-27 12:13:21 -06:00
Owner
Copy Link

Embedding boxes directly into the object structs exposes too much and can cause breakage. It also has the side effect of the objects fulfilling tomo.Box which can introduce other problems. Objects should encapsulate their box and only expose what they need to.

Embedding boxes directly into the object structs exposes too much and can cause breakage. It also has the side effect of the objects fulfilling tomo.Box which can introduce other problems. Objects should encapsulate their box and only expose what they need to.
sashakoshka commented 2024-06-27 12:59:56 -06:00
Author
Owner
Copy Link

As a counter argument: the issues are mainly due to themes setting attributes on boxes that conflict with manually set ones. Once Tomo transitions fully to data-driven theming that is simply overridden by manually set attributes, this will be less of an issue. Additionally, if an attribute needs to be encapsulated/controlled, the objects can override the setter.

As a counter argument: the issues are mainly due to themes setting attributes on boxes that conflict with manually set ones. Once Tomo transitions fully to data-driven theming that is simply overridden by manually set attributes, this will be less of an issue. Additionally, if an attribute needs to be encapsulated/controlled, the objects can override the setter.
sashakoshka changed title from Stop embedding Tomo boxes to Stop embedding Tomo boxes? 2024-06-27 13:00:04 -06:00
sashakoshka changed title from Stop embedding Tomo boxes? to Stop embedding Tomo boxes 2024-08-24 13:02:53 -06:00
sashakoshka commented 2024-08-24 13:03:15 -06:00
Author
Owner
Copy Link

Changes in Tomo 0.40.0-present have made this both viable and desirable

Changes in Tomo 0.40.0-present have made this both viable and desirable
sashakoshka commented 2024-08-24 23:43:46 -06:00
Author
Owner
Copy Link

This took an ENTIRE DAY!!!

This took an ENTIRE DAY!!!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tomo/objects#7
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?