tomo/xgbsel
tomo/xgbsel
1
0
Fork 0
Code Issues 3 Pull Requests Packages Projects Releases 4 Wiki Activity

Claims do not support INCR, leading to breakage with large data #1

New Issue
Open
opened 2024-07-05 21:13:08 -06:00 by sashakoshka · 2 comments
sashakoshka commented 2024-07-05 21:13:08 -06:00
Owner
Copy Link

Large files (such as images) can cause horrific breakage. More investigation is required.

Large files (such as images) can cause horrific breakage. More investigation is required.
sashakoshka commented 2024-07-06 02:14:59 -06:00
Author
Owner
Copy Link

This seems to be because, while we support receiving incremental data, we do not support sending it. If there is a lot of data, we set all of it on a window property at once, which is obviously very bad. There is literally an io.ReadAll call. Horrid. This tracks with the fact that the issue has only been observed with selection claims. The solution to this issue is therefore to support sending large data incrementally.

This seems to be because, while we support receiving incremental data, we do not support sending it. If there is a lot of data, we set all of it on a window property at once, which is obviously very bad. There is literally an io.ReadAll call. Horrid. This tracks with the fact that the issue has only been observed with selection claims. The solution to this issue is therefore to support sending large data incrementally.
sashakoshka changed title from Seems to break with large data to Claims do not support INCR, leading to breakage with large data 2024-07-06 02:16:14 -06:00
sashakoshka commented 2024-07-10 23:53:58 -06:00
Author
Owner
Copy Link

This cannot be implemented without breaking API changes (need another event handler). Additionally, NewClaim, NewRequest do not return an error when they really should. It looks like its time for a v2. Sad that I couldn't make a decent API from the start, but whatever.

This cannot be implemented without breaking API changes (need another event handler). Additionally, NewClaim, NewRequest do not return an error when they really should. It looks like its time for a v2. Sad that I couldn't make a decent API from the start, but whatever.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tomo/xgbsel#1
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?