tomo/xgbsel
tomo/xgbsel
1
0
Fork 0
Code Issues 3 Pull Requests Packages Projects Releases 4 Wiki Activity

Timestamp is improperly set #4

New Issue
Closed
opened 2024-07-06 02:09:27 -06:00 by sashakoshka · 0 comments
sashakoshka commented 2024-07-06 02:09:27 -06:00
Owner
Copy Link

NewClaim does not properly set the timestamp for when the selection was gained, instead using 0 (CurrentTime). It should instead use the timestamp of the event that caused the selection to be gained. We can't modify NewClaim to take in a timestamp parameter for two reasons:

  1. The API is stable
  2. We should still use CurrentTime when the claim was not triggered by an input event

Instead, we should create a different constructor that takes in a timestamp. Possibly NewClaimWithTimestamp or something.

NewClaim does not properly set the timestamp for when the selection was gained, instead using 0 (CurrentTime). It should instead use the timestamp of the event that caused the selection to be gained. We can't modify NewClaim to take in a timestamp parameter for two reasons: 1. The API is stable 2. We should still use CurrentTime when the claim was not triggered by an input event Instead, we should create a different constructor that takes in a timestamp. Possibly NewClaimWithTimestamp or something.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tomo/xgbsel#4
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?