Tests

emma commented

2024-02-28 07:14:07 +00:00

Owner

There should be tests for every utility. There should be no more new pull requests until there are tests for every utility currently in the tree. We can merge the existing ones and then make some tests for all of the utilities.

emma added the

enhancement

label 2024-02-28 07:14:07 +00:00

emma self-assigned this 2024-02-28 07:14:13 +00:00

trinity was assigned by emma

2024-02-28 07:14:13 +00:00

trinity commented

2024-02-29 04:05:07 +00:00

Owner

How should we do testing? I have a test.sh script I use for some of my own stuff - should we use that?

How should we do testing? I have a [test.sh](https://git.sr.ht/~trinity/src/tree/main/item/testing/test.sh) script I use for some of my own stuff - should we use that?

trinity commented

2024-03-01 11:33:23 +00:00

Owner

What do you think of TESTING?

What do you think of [TESTING](https://git.tebibyte.media/bonsai/coreutils/src/branch/testing/TESTING)?

emma commented

2024-03-02 05:32:29 +00:00

Author

Owner

What do you think of TESTING?

This should definitely be in the tests/ directory to be directly run by the Makefile. Please name it something like tools-testing.sh to be consistent with posix-compat.sh. We can make note of the script in README but I don’t know if anything beyond make test is worth mentioning outside the comments in the script.

> What do you think of [TESTING](https://git.tebibyte.media/bonsai/coreutils/src/branch/testing/TESTING)? This should definitely be in the `tests/` directory to be directly run by the Makefile. Please name it something like `tools-testing.sh` to be consistent with `posix-compat.sh`. We can make note of the script in `README` but I don’t know if anything beyond `make test` is worth mentioning outside the comments in the script.

emma commented

2024-03-02 05:33:11 +00:00

Author

Owner

Also, scripts should not be licensed under Creative Commons licenses, and the license information in non-plaintext files should be at the top.

trinity commented

2024-03-12 04:28:35 +00:00

Owner

What do you think of Testfile?

What do you think of [Testfile](https://git.tebibyte.media/bonsai/coreutils/src/branch/testing/Testfile)?

trinity commented

2024-03-12 16:58:59 +00:00

Owner

What if we just incorporated tests into the Makefile itself? So testing is done at build time and builds fail when tests fail. No Testfile, no TESTING, just additional testing lines in a build recipe to ensure everything works.

Tests #75