formatting, quoting, & typo

build-index.sh

@@ -1,9 +1,9 @@
 #!/bin/sh
 
-# defin the target dir
+# define the target dir
-parent=$(dirname "${BASH_SOURCE[0]}")
+parent="$(dirname "${BASH_SOURCE[0]}")"
-cd $parent; cd ../../../
+cd "$parent"; cd ../../../
-directory=$(pwd -P)
+directory="$(pwd -P)"
 
 today="$(date "+%Y-%m-%d")"
 
@@ -11,25 +11,30 @@ printf "Date: %s\n" "$today"
 
 for dirs in "$directory"/*; do
 	string="$(printf "---\n")"
-	area=$(basename "${dirs}")
+	area="$(basename "${dirs}")"
 	if [ "$area" != "System Volume Information" ]; then
 
 		string="$(printf "%stitle: %s\n" "$string" "$area")"
 		string="$(printf "%sdate: %s\n" "$string" "$today")"
 		string="$(printf "%s---\n\n" "$string")"
+
 		for cats in "$dirs"/*; do
-			category=$(basename "${cats}")
+			category="$(basename "$cats")"
 			string="$(printf "%s# %s\n\n" "$string" "$category")"
+
 			for ids in "$cats"/*; do
-				ident=$(basename "${ids}")
+				ident="$(basename "$ids")"
 				string="$(printf "%s* %s\n" "$string" "$ident")"
 			done
+
 			string="$(printf "%s\n" "$string")"
 		done
-	savedir="$directory/00-09 Index/00 Index/00.01 Index/"
+
-	fname="${area:0:5}.md"
+		savedir="$directory/00-09 Index/00 Index/00.01 Index/"
-	fullpath="$savedir$fname"
+		fname="${area:0:5}.md"
-	printf '%s\n' "$fullpath"
+		fullpath="$savedir$fname"
-	printf '%s' "$string" > "$fullpath"
+
+		printf '%s\n' "$fullpath"
+		printf '%s' "$string" > "$fullpath"
 	fi
 done