Emma Tebibyte emma
4 Followers · 13 Following
Repositories
21
 Projects Packages Public Activity Starred Repositories
14
emma closed pull request bonsai/harakit#142 2024-07-29 22:47:05 -06:00
Formatting
emma released 0.13.19 at bonsai/harakit 2024-07-29 22:46:23 -06:00
emma pushed to main at bonsai/harakit 2024-07-29 22:44:48 -06:00
6a5739ea9d Merge branch 'dj-formatting'
6bbccb3776 fop(1): fix minor optind bug, add some comments
fd13a7f189 swab(1): fix imports to be consistent
6c2b7b68fd dj(1): more better comments
8d23c7fbac dj(1): better ASV formatting and comments
Compare 86 commits »
emma pushed tag 0.13.19 to bonsai/harakit 2024-07-29 22:44:43 -06:00
emma pushed to dj-formatting at bonsai/harakit 2024-07-29 14:40:10 -06:00
6c2b7b68fd dj(1): more better comments
emma commented on pull request bonsai/harakit#142 2024-07-29 02:48:17 -06:00
Formatting

@trinity: let’s look this over once more together so we can get it merged.

emma pushed to dj-formatting at bonsai/harakit 2024-07-29 02:36:24 -06:00
361b34c50f npc(1): improves program_name resolution
emma commented on pull request bonsai/harakit#142 2024-07-28 18:34:53 -06:00
Formatting

I dislike this name because the type doesn’t only include options. The CalcType name is inherited from the library from which i forked this code.

emma pushed to dj-formatting at bonsai/harakit 2024-07-28 18:33:54 -06:00
44d461fb16 scrut(1): return program_name ternary to former position
emma pushed to dj-formatting at bonsai/harakit 2024-07-28 18:31:07 -06:00
338a3e7155 intcmp(1): move program_name ternary
emma pushed to dj-formatting at bonsai/harakit 2024-07-28 18:28:04 -06:00
6b9d13b8a0 fop(1): better opt matching
emma pushed to dj-formatting at bonsai/harakit 2024-07-28 17:50:36 -06:00
68e31058a8 intcmp(1): move program_name ternary
emma commented on pull request bonsai/harakit#142 2024-07-28 17:06:20 -06:00
Formatting

Assigning multiple bindings to avoid consecutive dereferences is in the spirit of this rule and is also enforced by the Rust compiler with lifetimes.

emma pushed to dj-formatting at bonsai/harakit 2024-07-28 01:17:40 -06:00
d2ae35eac9 fop(1): fixes glaring issue with newline handling
0f121cbac7 fop(1): more descriptive command arguments variable name
Compare 2 commits »
emma pushed to dj-formatting at bonsai/harakit 2024-07-28 00:36:00 -06:00
09193a14d5 fop(1): fixes unhandled i/o error
d5d13b84a7 STYLE: repition & Kernighan quote
Compare 2 commits »
emma commented on pull request bonsai/harakit#142 2024-07-28 00:31:03 -06:00
Formatting

Using exit() throughout the program is consistent.

emma commented on pull request bonsai/harakit#142 2024-07-28 00:21:52 -06:00
Formatting

If I make the Ok() arm match only Ok("d"), then I have to add Ok(_) to the existing Err arm or the Rust compiler will not compile the program.

emma pushed to dj-formatting at bonsai/harakit 2024-07-28 00:13:11 -06:00
aed64840ea STYLE: fixes some concerns
emma commented on pull request bonsai/harakit#142 2024-07-28 00:08:31 -06:00
Formatting

To line 50?

emma commented on pull request bonsai/harakit#142 2024-07-28 00:04:36 -06:00
Formatting

Please elaborate.