Emma Tebibyte emma
4 Followers · 14 Following
Repositories
19
 Projects Packages Public Activity Starred Repositories
15
emma commented on pull request bonsai/harakit#144 2024-07-15 14:00:47 -06:00
intcmp(1): rewrite in Rust

This comment needs to be more descriptive. What does ref cmp mean? Refer to comparison? Reflect comparison? Refine complexity?

emma commented on pull request bonsai/harakit#144 2024-07-15 14:00:47 -06:00
intcmp(1): rewrite in Rust

This block needs to be commented to explain what’s going on.

emma commented on pull request bonsai/harakit#144 2024-07-15 14:00:47 -06:00
intcmp(1): rewrite in Rust

These variable names can be the flags with a comment:

emma commented on pull request bonsai/harakit#144 2024-07-15 14:00:47 -06:00
intcmp(1): rewrite in Rust

This either needs to be commented or needs to have a more descriptive variable name. This is not a reference as far as I’m aware so I’m kind of confused why this is called that.

emma suggested changes for bonsai/harakit#144 2024-07-15 14:00:47 -06:00
intcmp(1): rewrite in Rust
emma pushed to dj-formatting at bonsai/harakit 2024-07-15 13:39:24 -06:00
9f2447ce94 STYLE: code block indentation edits and example
fbdf4f9c45 intcmp(1): switch formatting
Compare 2 commits »
emma commented on pull request bonsai/harakit#142 2024-07-15 13:34:43 -06:00
Formatting

if we're special-casing it for dj because of its wack source code, then it probably shouldn't a hard rule like this. Recent changes to STYLE reflect this.

emma pushed to dj-formatting at bonsai/harakit 2024-07-15 13:32:35 -06:00
806ddac8da dj(1): whitespace formatting
emma pushed to dj-formatting at bonsai/harakit 2024-07-15 13:30:13 -06:00
a0ed14a089 STYLE: example for trailing comma & add includes guideline
emma pushed to dj-formatting at bonsai/harakit 2024-07-15 13:17:58 -06:00
dc2a4a39ba swab(1): note what sysexits are being used
7ff14214c3 npc(1): move bit comment to be next to hex
a3ceb845e3 dj(1): revert some formatting changes
c2e6744e2b dj(1): revert changes to function return type formatting
71e98dbde7 dj.1: fixes more ambiguity
Compare 5 commits »
emma commented on pull request bonsai/harakit#142 2024-07-15 13:14:15 -06:00
Formatting

Yea, this should be on another line, I think this one was done in a sleepless fugue.

emma commented on pull request bonsai/harakit#142 2024-07-15 13:05:41 -06:00
Formatting

What do you think of my changes?

emma pushed to dj-formatting at bonsai/harakit 2024-07-15 13:05:22 -06:00
e9496cb4a5 dj.1: fixes ambiguity and false information
789046f694 STYLE: removes do while constraint & reword indentation rule
Compare 2 commits »
emma commented on pull request bonsai/harakit#142 2024-07-15 13:00:18 -06:00
Formatting

I meant the total size of the written data; I will say that.

emma commented on pull request bonsai/harakit#142 2024-07-15 12:59:35 -06:00
Formatting

I agree with this generally; however, dj(1)’s source code should be special-cased to utilize this practice as it is difficult to figure which do applies to which while.

emma commented on pull request bonsai/harakit#142 2024-07-15 12:57:54 -06:00
Formatting

This rule is imported directly from the default behavior of rustfmt(1).

emma commented on pull request bonsai/harakit#142 2024-07-15 12:57:13 -06:00
Formatting

Unindented cases are a pain in the ass to read.

emma commented on pull request bonsai/harakit#142 2024-07-15 12:56:29 -06:00
Formatting

They increase readability substantially.

emma commented on pull request bonsai/harakit#143 2024-07-15 12:55:47 -06:00
mm(1): rewritten in Rust

Merged.

emma closed pull request bonsai/harakit#143 2024-07-15 12:55:47 -06:00
mm(1): rewritten in Rust