parser.Parser should not be exported #28

New Issue

Closed

opened 2024-02-10 00:38:55 +00:00 by sashakoshka · 1 comment

sashakoshka commented

2024-02-10 00:38:55 +00:00

Owner

parser.Tree has a Parse() method that creates a new parser and it to parse tokens into itself. It does not make sense for Parser to exist without a Tree because Parser needs Tree to do anything at all. For this reason, and for consistency with analyzer, parser.Parser should be private.

parser.Tree has a Parse() method that creates a new parser and it to parse tokens into itself. It does not make sense for Parser to exist without a Tree because Parser needs Tree to do anything at all. For this reason, and for consistency with analyzer, parser.Parser should be private.

sashakoshka added the

package: parser

labels 2024-02-10 00:38:55 +00:00

sashakoshka commented

2024-02-10 23:58:22 +00:00

Author

Owner

Remedied by 813a95bc8c

Remedied by https://git.tebibyte.media/sashakoshka/fspl/commit/813a95bc8ccd833f31ce90fa6e7d0b317843b9bd

sashakoshka closed this issue

2024-02-10 23:58:22 +00:00

Sign in to join this conversation.

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fspl/fspl#28

No description provided.