fspl/fspl
fspl/fspl
1
0
Fork 0
Code Issues 16 Pull Requests Packages Projects 1 Releases 6 Wiki Activity

Incorrect behavior when trying to bit-cast to and from pointers #47

New Issue
Open
opened 2024-02-26 22:20:15 -07:00 by sashakoshka · 4 comments
sashakoshka commented 2024-02-26 22:20:15 -07:00
Owner
Copy Link

Source A:

[main argc:I32 argv:**Byte]: I32 'main' = {
	argvindex:Index = [+ [~~Index argv] 1]
	argv = [~~ **Byte argvindex]
	0
}

Behavior A:

llc-16: error: llc-16: <stdin>:11:15: error: invalid cast opcode for cast from 'ptr' to 'i64'
        %5 = bitcast ptr %4 to %"AAAAAAAAAAAAAAAAAAAAAA==::Index"

Source B:

[main argc:I32 argv:**Byte]: I32 'main' = {
	argv = [~~ **Byte [+ [~~Index argv] 1]]
	cstdio::[puts [.argv]]
	0
}

Behavior B:

    common_test.go:86: compiler returned error: /test-data/data/argv/main.fspl:2:20: expected **Byte
        2    |         argv = [~~ **Byte [+ [~~Index argv] 1]]
                                         ^^^^^^^^^^^^^^^^^^^^

The generator should never produce invalid IR (given a well formed AST), and the analyzer should be more consistent. The operation in question (bit casting a pointer to an integer and back) is necessary for working with C code and should be allowed and supported.

Source A: ``` [main argc:I32 argv:**Byte]: I32 'main' = { argvindex:Index = [+ [~~Index argv] 1] argv = [~~ **Byte argvindex] 0 } ``` Behavior A: ``` llc-16: error: llc-16: <stdin>:11:15: error: invalid cast opcode for cast from 'ptr' to 'i64' %5 = bitcast ptr %4 to %"AAAAAAAAAAAAAAAAAAAAAA==::Index" ``` Source B: ``` [main argc:I32 argv:**Byte]: I32 'main' = { argv = [~~ **Byte [+ [~~Index argv] 1]] cstdio::[puts [.argv]] 0 } ``` Behavior B: ``` common_test.go:86: compiler returned error: /test-data/data/argv/main.fspl:2:20: expected **Byte 2 | argv = [~~ **Byte [+ [~~Index argv] 1]] ^^^^^^^^^^^^^^^^^^^^ ``` The generator should never produce invalid IR (given a well formed AST), and the analyzer should be more consistent. The operation in question (bit casting a pointer to an integer and back) is necessary for working with C code and should be allowed and supported.
sashakoshka added the
bug
package: analyzer
package: generator
 labels 2024-02-26 22:20:15 -07:00
sashakoshka commented 2024-02-26 22:23:10 -07:00
Author
Owner
Copy Link

Need to uncomment

compiler/compiler_test.go Line 43 in 60c49a1d9a
// TODO: uncomment once #47 has been dealt with
when this has been resolved

Need to uncomment https://git.tebibyte.media/fspl/fspl/src/commit/60c49a1d9a7093cfe5ec58b2934b2abb0157b302/compiler/compiler_test.go#L43 when this has been resolved
sashakoshka added the
status
ongoing
 label 2024-02-28 09:07:21 -07:00
sashakoshka commented 2024-02-28 11:38:50 -07:00
Author
Owner
Copy Link

35479e68a8 partially fixes the generator side of this. These symptoms revealed more possible buggy behavior, see comments in the commit. Need more tests for these cases and to fix them.

https://git.tebibyte.media/fspl/fspl/commit/35479e68a8e14f54a1c3651c05542c4e12437cc6 partially fixes the generator side of this. These symptoms revealed more possible buggy behavior, see comments in the commit. Need more tests for these cases and to fix them.
sashakoshka changed title from Bizarre behavior when trying to cast pointer to Index to Incorrect behavior when trying to cast to and from pointers 2024-02-28 11:53:04 -07:00
sashakoshka changed title from Incorrect behavior when trying to cast to and from pointers to Incorrect behavior when trying to bit-cast to and from pointers 2024-02-28 11:53:17 -07:00
sashakoshka commented 2024-02-28 17:35:03 -07:00
Author
Owner
Copy Link

The analyzer side of this issue has been completely remedied by #50

The analyzer side of this issue has been completely remedied by #50
sashakoshka removed the
package: analyzer
 label 2024-02-28 17:35:14 -07:00
sashakoshka commented 2024-02-28 18:10:20 -07:00
Author
Owner
Copy Link

Putting this on the backburner for now as fully fixing this in the generator is non-trivial, and use cases for bit casting crazy stuff like structs to pointers are a bit slim

Putting this on the backburner for now as *fully* fixing this in the generator is non-trivial, and use cases for bit casting crazy stuff like structs to pointers are a bit slim
sashakoshka added
status
backburner
 and removed
status
ongoing
 labels 2024-02-28 18:10:49 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something is not working

  
documentation

Doc comments, READMEs, etc.

  
enhancement

New feature

  
help wanted

Need some help

  
management

The repository itself

  
package: analyzer

Semantic analyzer

  
package: compiler

Compiler control

  
package: errors

Error reporting and formatting

  
package: fsplc

FSPL compiler program

  
package: generator

Code generator

  
package: lexer

Token lexer

  
package: llvm

Specialized LLVM IR generator

  
package: parser

AST parser

  
performance

compiler go brrr

  
priority

Must be dealt with soon

  
question

More information is needed

  
refactor

Clean-up on aisle FSPL

  
status
backburner
Not quite wontfix

  
status
duplicate
This issue or pull request already exists

  
status
invalid
Something is wrong

  
status
ongoing
Being dealt with, but it will take a bit

  
status
wontfix
This won't be fixed

  
test

Test cases

No Label
bug
documentation
enhancement
help wanted
management
package: analyzer
package: compiler
package: errors
package: fsplc
package: generator
package: lexer
package: llvm
package: parser
performance
priority
question
refactor
status
backburner
status
duplicate
status
invalid
status
ongoing
status
wontfix
test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fspl/fspl#47
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?