• Joined on 2022-02-27
mars merged pull request mars/breed#9 2023-04-12 22:56:00 +00:00
reduced binary size
mars pushed to main at emma/breed 2023-04-12 22:53:49 +00:00
f1be638ea7 Merge branch 'main' into main
814d4b116b More efficient scope style lookups
b351dbbcbb Faster syntax highlighting with a style stack
4f6f17d066 Oops! accidentally set dirty flag every draw
83872583e0 Buffer line styling
Compare 7 commits »
mars pushed to main at mars/breed 2023-04-12 22:38:21 +00:00
814d4b116b More efficient scope style lookups
b351dbbcbb Faster syntax highlighting with a style stack
Compare 2 commits »
mars pushed to main at mars/breed 2023-04-12 22:03:30 +00:00
4f6f17d066 Oops! accidentally set dirty flag every draw
mars pushed to main at mars/breed 2023-04-12 21:56:25 +00:00
83872583e0 Buffer line styling
742ed97819 Defer stdout flush until end of draw
afaf3ab0fe Add line command
Compare 3 commits »
mars pushed to main at mars/breed 2023-04-12 21:27:05 +00:00
1f33402a42 Parse commands as strings + wq
mars pushed to main at mars/breed 2023-04-12 21:16:11 +00:00
5bf1212b2a Import Path in main.rs
mars pushed to main at mars/breed 2023-04-12 21:15:01 +00:00
7d46cbcf9b Live theme reload
b7f9c8ba2e pub mode-related types
7fff70ce84 Move (some) actions to separate module
Compare 4 commits »
mars pushed to main at mars/breed 2023-04-12 21:13:39 +00:00
aa013fc422 Merge pull request 'basic file handling' (#7) from emma/breed:main into main
4d79d7b946 Merge remote-tracking branch 'upstream/main'
6ef5182cea fixed file path resolution
c06b39239c Merge remote-tracking branch 'upstream/main'
0ff694c6c1 better command parsing with file name argument for :w
Compare 6 commits »
mars merged pull request mars/breed#7 2023-04-12 21:13:39 +00:00
basic file handling
mars pushed to emma-main at mars/breed 2023-04-12 16:57:43 +00:00
beab2783f7 Merge branch 'main' of https://git.tebibyte.media/emma/breed into emma-main
mars created branch emma-main in mars/breed 2023-04-12 16:57:43 +00:00
mars pushed to main at mars/breed 2023-04-12 16:53:16 +00:00
539360114a WIP Rose Pine default theme
3d03c90c7b WIP syntax highlighting
51622bf6fd Ignore style modifiers and underline for now
7137744122 Merge palette table with default palette
78b24c4203 Support 0-length scopes
Compare 8 commits »
mars commented on pull request mars/breed#7 2023-04-12 16:51:48 +00:00
basic file handling

I think it's much more straight-forward just to match the strings.

mars suggested changes for mars/breed#7 2023-04-12 16:27:07 +00:00
basic file handling

Very, very, very good in general but I had some questions.

mars commented on pull request mars/breed#7 2023-04-12 16:27:07 +00:00
basic file handling

This is a very good function, but can we make this function return std::io::Result<()> instead? I think that displaying the error as a string should be the job of whatever command is saving the file.

mars commented on pull request mars/breed#7 2023-04-12 16:27:07 +00:00
basic file handling

I don't think that splitting up commands into chars before processing like this is the right approach. For example, q! would be treated as two separate commands despite it performing a different operation than q.

mars commented on pull request mars/breed#7 2023-04-12 16:27:07 +00:00
basic file handling

Same kind of deal here; what if there is more than one argument?

mars commented on pull request mars/breed#7 2023-04-12 16:27:07 +00:00
basic file handling

If "q" is given multiple command parts, it still quits without issuing a warning. I'm not sure if this should exit silently even when given more arguments than expected. What do you think?

mars pushed to main at mars/breed 2023-04-12 04:21:46 +00:00
b048eba60c Merge pull request 'o-insert' (#5) from roux/breed:o-insert into main
8cb37a7820 Capital O insert mode
badd6a0b71 fixed outdated code
36bbb3b77b resolve merge conflict
f5ea473328 cargo fmt
Compare 6 commits »