minecrust
/
hopper
4
0
Fork 2
Code Issues 9 Pull Requests 2 Projects 1 Releases Wiki Activity

Move functions into new HopperClient struct #10

Merged
mars merged 1 commits from HopperClient-rewrite into main 2022-09-06 05:12:07 +00:00
Conversation 0 Commits 1 Files Changed 3 +138 -119
spookdot commented 2022-08-25 18:29:06 +00:00
Member
Copy Link

I've taken the functions that do API calls and also the config data and moved them into the new separate HopperClient struct. That way as suggested we can have them all in one place

I've taken the functions that do API calls and also the config data and moved them into the new separate HopperClient struct. That way as suggested we can have them all in one place
spookdot added 1 commit 2022-08-25 18:29:07 +00:00
mars requested review from mars 2022-08-28 05:24:51 +00:00
mars approved these changes 2022-09-06 05:12:03 +00:00
mars left a comment
Owner
Copy Link

Wonderful job, thank you! This may require some refactoring in the future to get rid of the copies of the config, but it's not necessary at all right now since the config structs carry basically no data.

Wonderful job, thank you! This may require some refactoring in the future to get rid of the copies of the config, but it's not necessary at all right now since the config structs carry basically no data.
mars merged commit 12cda62da0 into main 2022-09-06 05:12:07 +00:00
mars deleted branch HopperClient-rewrite 2022-09-06 05:12:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mars
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: minecrust/hopper#10
No description provided.
Delete Branch "HopperClient-rewrite"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?