Add hru(1) #50

Closed
emma wants to merge 0 commits from hru into main
Owner

Closes #33

Closes #33
emma added the
enhancement
label 2024-02-08 04:00:22 +00:00
emma self-assigned this 2024-02-08 04:00:22 +00:00
emma added 1 commit 2024-02-08 04:00:23 +00:00
emma changed title from Add hru(1) to WIP: Add hru(1) 2024-02-08 04:01:00 +00:00
emma added 1 commit 2024-02-08 04:43:13 +00:00
trinity reviewed 2024-02-08 23:38:57 +00:00
src/hru.rs Outdated
@ -0,0 +86,4 @@
Ok(f) => f,
Err(err) => {
eprintln!("{}: {}", argv[0], err);
exit(1);
Owner

Why 1 and not a sysexit?

Why `1` and not a sysexit?
Author
Owner

I’ve neither requested your review nor moved this out of WIP. That means this is not yet nearing completion. Here you will find your answer.

I’ve neither requested your review nor moved this out of WIP. That means this is not yet nearing completion. Here you will find your answer.
emma marked this conversation as resolved
emma added 1 commit 2024-02-14 00:33:06 +00:00
emma added 1 commit 2024-02-14 00:51:04 +00:00
emma changed title from WIP: Add hru(1) to Add hru(1) 2024-02-14 00:51:14 +00:00
emma requested review from trinity 2024-02-14 00:51:19 +00:00
emma requested review from silt 2024-02-14 00:51:21 +00:00
emma added 1 commit 2024-02-14 06:56:42 +00:00
emma added 1 commit 2024-02-14 07:07:44 +00:00
emma added 1 commit 2024-02-15 06:32:30 +00:00
emma added 1 commit 2024-02-17 04:38:56 +00:00
trinity approved these changes 2024-02-17 16:36:57 +00:00
trinity left a comment
Owner

Looks alright.

Looks alright.
docs/hru.1 Outdated
@ -0,0 +17,4 @@
Hru takes any whole number in the standard input and, to the standard output,
prints the equivalent number in the most human-readable unit defined by the
International System of Units.
Owner

Which unit? Kilometers?

Which unit? Kilometers?
emma marked this conversation as resolved
@ -0,0 +27,4 @@
use sysexits::{ EX_DATAERR, EX_SOFTWARE };
const LIST: [(u32, &str); 10] = [
Owner

What's the significance of 10 here?

What's the significance of 10 here?
Author
Owner

This is the size of the statically allocated array.

This is the size of the statically allocated array.
emma marked this conversation as resolved
emma added 1 commit 2024-02-18 21:50:01 +00:00
emma added 1 commit 2024-02-18 21:59:44 +00:00
emma requested review from trinity 2024-02-18 22:05:19 +00:00
emma added 1 commit 2024-02-24 04:59:01 +00:00
emma added 1 commit 2024-02-24 05:11:57 +00:00
emma closed this pull request 2024-02-24 05:17:32 +00:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: bonsai/coreutils#50
No description provided.