dj(1) segfaults if trying to skip in stdout #112

New Issue

emma · 2024-06-04T22:16:48Z

emma commented

2024-06-04 22:16:48 +00:00

$ dj -S 1
zsh: segmentation fault  dj -S 1

``` $ dj -S 1 zsh: segmentation fault dj -S 1 ```

emma added the

bug

label 2024-06-04 22:16:48 +00:00

trinity was assigned by emma

2024-06-04 22:16:51 +00:00

emma changed title from ~~`dj(1)` segfaults if trying to seek into stdout~~ to `dj(1)` segfaults if trying to skip in stdout

2024-06-04 22:17:10 +00:00

trinity commented

2024-06-06 06:29:39 +00:00

This is definitely happening in Io_fdseek. I currently don't have a programming environment but when I have one set up I'll debug and fix.

This is definitely happening in `Io_fdseek`. I currently don't have a programming environment but when I have one set up I'll debug and fix.

emma commented

2024-06-30 03:56:54 +00:00

@trinity this issue is still not fixed in main.

trinity commented

2024-07-01 14:50:27 +00:00

I was gonna get to it in the dj refactor but wanted the API (options) changes in as soon as possible as that change was potentially breaking. One of the reasons for the refactor was to make this bug easier to spot. Obviously no stability is expected in our alpha phase but I wanna iron out all the big things sooner rather than later.

Looking at the main tree as I'm not at my computer, I don't see any possibility of segfault other than a buffer overflow in Io_fdseek. That should be straightforward to solve (perhaps it's an off-by-one?).

I was gonna get to it in the dj refactor but wanted the API (options) changes in as soon as possible as that change was potentially breaking. One of the reasons for the refactor was to make this bug easier to spot. Obviously no stability is expected in our alpha phase but I wanna iron out all the big things sooner rather than later. Looking at the main tree as I'm not at my computer, I don't see any possibility of segfault other than a buffer overflow in `Io_fdseek`. That should be straightforward to solve (perhaps it's an off-by-one?).

Sign in to join this conversation.