bonsai/harakit
5
4
Fork 3
Code Issues 43 Pull Requests 3 Projects 1 Releases 36 Activity

dj(1) segfaults if trying to skip in stdout #112

New Issue
Closed
opened 2024-06-04 16:16:48 -06:00 by emma · 3 comments
emma commented 2024-06-04 16:16:48 -06:00
Owner
Copy Link
Copy Source
$ dj -S 1
zsh: segmentation fault  dj -S 1
``` $ dj -S 1 zsh: segmentation fault dj -S 1 ```
emma added the bug label 2024-06-04 16:16:48 -06:00
trinity was assigned by emma 2024-06-04 16:16:51 -06:00
emma changed title from `dj(1)` segfaults if trying to seek into stdout to `dj(1)` segfaults if trying to skip in stdout 2024-06-04 16:17:10 -06:00
trinity commented 2024-06-06 00:29:39 -06:00
Owner
Copy Link
Copy Source

This is definitely happening in Io_fdseek. I currently don't have a programming environment but when I have one set up I'll debug and fix.

This is definitely happening in `Io_fdseek`. I currently don't have a programming environment but when I have one set up I'll debug and fix.
emma commented 2024-06-29 21:56:54 -06:00
Author
Owner
Copy Link
Copy Source

@trinity this issue is still not fixed in main.

@trinity this issue is still not fixed in main.
trinity commented 2024-07-01 08:50:27 -06:00
Owner
Copy Link
Copy Source

I was gonna get to it in the dj refactor but wanted the API (options) changes in as soon as possible as that change was potentially breaking. One of the reasons for the refactor was to make this bug easier to spot. Obviously no stability is expected in our alpha phase but I wanna iron out all the big things sooner rather than later.

Looking at the main tree as I'm not at my computer, I don't see any possibility of segfault other than a buffer overflow in Io_fdseek. That should be straightforward to solve (perhaps it's an off-by-one?).

I was gonna get to it in the dj refactor but wanted the API (options) changes in as soon as possible as that change was potentially breaking. One of the reasons for the refactor was to make this bug easier to spot. Obviously no stability is expected in our alpha phase but I wanna iron out all the big things sooner rather than later. Looking at the main tree as I'm not at my computer, I don't see any possibility of segfault other than a buffer overflow in `Io_fdseek`. That should be straightforward to solve (perhaps it's an off-by-one?).
emma closed this issue 2024-07-08 13:27:59 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 joke
you are silly!
 question
More information is needed
 wontfix
This won't be fixed
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
emma (Emma Tebibyte) nitori silt (silt!) soup (Soup For My Family) trinity (dtb)
No Assignees trinity
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonsai/harakit#112