bonsai/harakit
4
4
Fork 3
Code Issues 41 Pull Requests 2 Projects 1 Releases 35 Activity

README: added build information and copyright #51

Closed
emma wants to merge 0 commits from readme-changes into main
pull from: readme-changes
merge into: bonsai:main
Conversation 4 Commits - Files Changed -
emma commented 2024-02-07 21:28:51 -07:00
Owner
Copy Link

Closes #24

Closes #24
emma added the
enhancement
 label 2024-02-07 21:28:51 -07:00
emma self-assigned this 2024-02-07 21:28:51 -07:00
emma added 1 commit 2024-02-07 21:28:52 -07:00
emma requested review from trinity 2024-02-07 21:28:56 -07:00
emma requested review from silt 2024-02-07 21:28:56 -07:00
emma added 1 commit 2024-02-07 21:39:08 -07:00
emma added 1 commit 2024-02-15 17:40:21 -07:00
trinity reviewed 2024-02-16 13:37:12 -07:00
README Outdated
@ -20,0 +22,4 @@
The coreutils require minimal dependencies for building:
· bindgen(1)
· cc(1) with -idirafter
trinity commented 2024-02-16 13:37:12 -07:00
Owner
Copy Link

It looks like cpp(1) needs -idirafter, not cc(1).

It [looks like](https://git.tebibyte.media/bonsai/coreutils/src/branch/main/Makefile#L52) cpp(1) needs `-idirafter`, not cc(1).
emma marked this conversation as resolved
trinity reviewed 2024-02-16 13:37:53 -07:00
README
@ -20,0 +38,4 @@
To build with a different compiler than the default:
$ make CC=clang # different C compiler than cc(1)
$ make RUSTC=gccrs # different Rust compiler than rustc(1)
trinity commented 2024-02-16 13:37:53 -07:00
Owner
Copy Link

I don't think these two comments are necessary, it's apparent what is changing.

I don't think these two comments are necessary, it's apparent what is changing.
emma marked this conversation as resolved
trinity reviewed 2024-02-16 13:42:08 -07:00
README Outdated
@ -20,0 +23,4 @@
· bindgen(1)
· cc(1) with -idirafter
· cp(1p)
trinity commented 2024-02-16 13:42:08 -07:00
Owner
Copy Link

I think requiring a "POSIX-like operating environment" would be sufficient here. Maybe:

"The coreutils require a POSIX-like operating environment to compile, including a C compiler (cc is used by default) and preprocessor (cpp by default), Rust compiler (rustc by default), and POSIX-compatible Make utility (make is used by default; both GNU and BSD Make should work).

I think requiring a "POSIX-like operating environment" would be sufficient here. Maybe: "The coreutils require a POSIX-like operating environment to compile, including a C compiler (`cc` is used by default) and preprocessor (`cpp` by default), Rust compiler (`rustc` by default), and POSIX-compatible Make utility (`make` is used by default; both GNU and BSD Make should work).
emma marked this conversation as resolved
trinity approved these changes 2024-02-16 13:42:52 -07:00
trinity left a comment
Owner
Copy Link

The changes as-is are alright, you can take my suggestions or leave 'em.

The changes as-is are alright, you can take my suggestions or leave 'em.
emma added 1 commit 2024-02-16 21:02:49 -07:00
emma closed this pull request 2024-02-16 21:04:04 -07:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
silt
trinity
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
joke
you are silly!
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
emma nitori silt trinity
No Assignees emma
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonsai/harakit#51
No description provided.
Delete Branch "readme-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?