bonsai/harakit
5
4
Fork 3
Code Issues 37 Pull Requests 7 Projects 1 Releases 21 Activity

WIP: testing #96

Draft
emma wants to merge 23 commits from testing into main
pull from: testing
merge into: bonsai:main
Conversation 3 Commits 23 Files Changed 18 +8 -8
9 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4ad9e0da92 - Show all commits

2
tests/bonsai/dj.sh
View File

@ -7,7 +7,7 @@
# permitted in any medium without royalty provided the copyright notice and this
# notice are preserved. This file is offered as-is, without any warranty.
. tests/bonsai/aliases
. tests/bonsai/test_env
! dj -h

2
tests/bonsai/false.sh
View File

@ -7,7 +7,7 @@
# permitted in any medium without royalty provided the copyright notice and this
# notice are preserved. This file is offered as-is, without any warranty.
. tests/bonsai/aliases
. tests/bonsai/test_env
! false
! false -h
emma marked this conversation as resolved
trinity commented 2024-04-27 01:57:11 +00:00
Review
Copy Link

GNU false(1), a notoriously POSIX non-compliant implementation, would pass here, as (if I recall) it returns EXIT_FAILURE for improper usage. It shouldn't pass, though, because it prints a usage text to the standard output when usage help or version information are queried.

I think another good test would be false --help | wc -c | xargs test 0 =, though you should double check the exit statuses here before adding it.

GNU false(1), a notoriously POSIX non-compliant implementation, would pass here, as (if I recall) it returns `EXIT_FAILURE` for improper usage. It shouldn't pass, though, because [it prints a usage text to the standard output when usage help or version information are queried](https://git.savannah.gnu.org/cgit/coreutils.git/tree/src/true.c#n36). I think another good test would be `false --help | wc -c | xargs test 0 =`, though you should double check the exit statuses here before adding it.
emma commented 2024-04-27 02:53:33 +00:00
Review
Copy Link

Why would we test for GNU extensions in our implementation of true(1)?

Why would we test for GNU extensions in our implementation of `true(1)`?
trinity commented 2024-04-27 13:25:37 +00:00
Review
Copy Link

It's testing for bloat. It drives home the fact that we will not compromise on making good, simple tools. If we did our tests would fail us.

It's testing for bloat. It drives home the fact that we *will not* compromise on making good, simple tools. If we did our tests would fail us.
emma commented 2024-04-27 19:04:00 +00:00
Review
Copy Link

But if we changed our minds, we could just change our test, and if someone made a PR with changes like that, they would just change the test too.

But if we changed our minds, we could just change our test, and if someone made a PR with changes like that, they would just change the test too.
trinity commented 2024-04-29 02:04:10 +00:00
Review
Copy Link

That's true. I suppose such a test isn't necessary.

That's true. I suppose such a test isn't necessary.

2
tests/bonsai/fop.sh
View File

@ -6,7 +6,7 @@
# permitted in any medium without royalty provided the copyright notice and this
# notice are preserved. This file is offered as-is, without any warranty.
. tests/bonsai/aliases
. tests/bonsai/test_env
! fop -h

2
tests/bonsai/hru.sh
View File

@ -6,7 +6,7 @@
# permitted in any medium without royalty provided the copyright notice and this
# notice are preserved. This file is offered as-is, without any warranty.
. tests/bonsai/aliases
. tests/bonsai/test_env
alias strcmp="$BIN/strcmp"
alias rpn="$BIN/rpn"

2
tests/bonsai/intcmp.sh
View File

@ -7,7 +7,7 @@
# permitted in any medium without royalty provided the copyright notice and this
# notice are preserved. This file is offered as-is, without any warranty.
. tests/bonsai/aliases
. tests/bonsai/test_env
intcmp -e 3 3 3
intcmp -g 3 2 1

2
tests/bonsai/mm.sh
View File

@ -6,7 +6,7 @@
# permitted in any medium without royalty provided the copyright notice and this
# notice are preserved. This file is offered as-is, without any warranty.
. tests/bonsai/aliases
. tests/bonsai/test_env
exec 3>&1

2
tests/bonsai/strcmp.sh
View File

@ -7,7 +7,7 @@
# permitted in any medium without royalty provided the copyright notice and this
# notice are preserved. This file is offered as-is, without any warranty.
. tests/bonsai/aliases
. tests/bonsai/test_env
strcmp equals equals
! strcmp inequals equals

0
tests/bonsai/aliases → tests/bonsai/test_env
View File

2
tests/bonsai/true.sh
View File

@ -7,7 +7,7 @@
# permitted in any medium without royalty provided the copyright notice and this
# notice are preserved. This file is offered as-is, without any warranty.
. tests/bonsai/aliases
. tests/bonsai/test_env
true
true -h