Emma Tebibyte emma
emma commented on pull request bonsai/harakit#146 2024-09-10 02:23:22 -06:00
Replace scrut(1) with fileis(1)

Line 59 happens when a file is non-existent, which means it's failed the test.

I see now that line 59 should stay the same.

emma commented on pull request bonsai/harakit#161 2024-09-10 02:22:12 -06:00
optimizations

From OpenBSD man 2 pledge:

     Passing NULL to promises or execpromises specifies to not change the
     current value.

It seems a number of these should be…

emma pushed to style-c at bonsai/harakit 2024-09-10 02:05:05 -06:00
f66fdef9c3 STYLE: avoid unbounded loops
emma pushed to style-c at bonsai/harakit 2024-09-10 02:00:18 -06:00
b56a66f980 STYLE: fixes default case in example
emma pushed to style-c at bonsai/harakit 2024-09-07 12:51:32 -06:00
f6559b464a STYLE: fix minor issues
emma closed issue bonsai/harakit#147 2024-09-06 14:16:39 -06:00
README is still too vague
emma pushed to man-fixes at bonsai/harakit 2024-09-05 17:12:49 -06:00
accec33301 Makefile: fixes abuse of relative paths
emma deleted branch rdme from bonsai/harakit 2024-09-05 17:03:50 -06:00
emma closed pull request bonsai/harakit#149 2024-09-05 17:03:42 -06:00
README: fix vagueness
emma commented on pull request bonsai/harakit#149 2024-09-05 17:03:42 -06:00
README: fix vagueness

Merged.

emma pushed to main at bonsai/harakit 2024-09-05 17:02:48 -06:00
444e682f02 Merge branch 'rdme'
e889159619 CONTRIBUTING: made better
d2f8fb8106 README: improvements, community links
cd875df547 README: attempt to clarify intent
Compare 4 commits »
emma pushed to style-c at bonsai/harakit 2024-09-05 15:55:51 -06:00
790b12fb40 STYLE: changes numbering scheme to transcend headers, fixes minor errors
emma commented on pull request bonsai/harakit#156 2024-09-05 13:41:24 -06:00
STYLE: make rules more granular and consistent, add examples

I made changes to allow simple citation of the guidelines and clarify some of the visual hierarchy of the document.

emma approved bonsai/harakit#149 2024-09-05 13:39:32 -06:00
README: fix vagueness
emma created pull request bonsai/harakit#162 2024-09-05 13:10:53 -06:00
Makefile: fixes manpage installation location
emma pushed to man-fixes at bonsai/harakit 2024-09-05 12:58:12 -06:00
fde682a10e Makefile: fixes manpage installation location
emma created branch man-fixes in bonsai/harakit 2024-09-05 12:58:12 -06:00
emma pushed to style-c at bonsai/harakit 2024-09-05 12:44:23 -06:00
4cb5ea78d7 STYLE: improves clarity, focus, distribution of items, adds more gripes, includes usage text style
emma commented on pull request bonsai/harakit#146 2024-09-05 00:34:01 -06:00
Replace scrut(1) with fileis(1)

Should this program return EX_IOERR on line 59 and EX_SOFTWARE on line 81?

I see now that line 81 should stay the same.

emma commented on pull request bonsai/harakit#146 2024-09-05 00:33:40 -06:00
Replace scrut(1) with fileis(1)

@trinity: In the middle of this review I decided to simply make a patch and send it your way via instant messaging.