bonsai/harakit
5
4
Fork 3
Code Issues 42 Pull Requests 5 Projects 1 Releases 34 Activity

Set aside broken npc(1) test for now #164

Closed
emma wants to merge 0 commits from npc-broken-tests into main
pull from: npc-broken-tests
merge into: bonsai:main
Conversation 3 Commits - Files Changed -
emma commented 2025-02-24 23:19:14 -07:00
Owner
Copy Link
No description provided.
emma added the
bug
help wanted
question
 labels 2025-02-24 23:19:14 -07:00
emma added 2 commits 2025-02-24 23:19:15 -07:00
emma commented 2025-02-24 23:20:36 -07:00
Author
Owner
Copy Link

Merged.

Merged.
emma closed this pull request 2025-02-24 23:20:36 -07:00
emma deleted branch npc-broken-tests 2025-02-24 23:22:23 -07:00
trinity commented 2025-03-21 15:06:44 -06:00
Owner
Copy Link

That test always sucked. I'm considering filing a PR to erase it because it's nearly unmaintainable. Thoughts?

That test always sucked. I'm considering filing a PR to erase it because it's nearly unmaintainable. Thoughts?
emma commented 2025-03-24 19:24:25 -06:00
Author
Owner
Copy Link

We need to rework all of the npc(1) tests to be more readable.

We need to rework all of the `npc(1)` tests to be more readable.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
joke

you are silly!

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
joke
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: bonsai/harakit#164
No description provided.
Delete Branch "npc-broken-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?