sashakoshka/go-gemini
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

request: Allow User in URLs

Browse Source
This commit is contained in:
Adnan Maolood 2021-02-16 00:55:54 -05:00
parent 2157b35c0b
commit 779be8b95b
2 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
request.go
View File

@ -102,20 +102,12 @@ func ReadRequest(r io.Reader) (*Request, error) {
if err != nil { if err != nil {
return nil, err return nil, err
} }
if u.User != nil {
// User is not allowed
return nil, ErrInvalidURL
}
return &Request{URL: u}, nil return &Request{URL: u}, nil
} }
// Write writes a Gemini request in wire format. // Write writes a Gemini request in wire format.
// This method consults the request URL only. // This method consults the request URL only.
func (r *Request) Write(w *bufio.Writer) error { func (r *Request) Write(w *bufio.Writer) error {
if r.URL.User != nil {
// User is not allowed
return ErrInvalidURL
}
url := r.URL.String() url := r.URL.String()
if len(url) > 1024 { if len(url) > 1024 {
return ErrInvalidRequest return ErrInvalidRequest

16
request_test.go
View File

@ -46,14 +46,6 @@ func TestReadRequest(t *testing.T) {
Raw: "gemini://example.com", Raw: "gemini://example.com",
Err: io.EOF, Err: io.EOF,
}, },
{
Raw: "gemini://user:password@example.com\r\n",
Err: ErrInvalidURL,
},
{
Raw: "https://user:password@example.net\r\n",
Err: ErrInvalidURL,
},
{ {
// 1030 bytes // 1030 bytes
Raw: maxURL + "xxxxxx", Raw: maxURL + "xxxxxx",
@ -121,14 +113,6 @@ func TestWriteRequest(t *testing.T) {
Req: newRequest(maxURL + "x"), Req: newRequest(maxURL + "x"),
Err: ErrInvalidRequest, Err: ErrInvalidRequest,
}, },
{
Req: newRequest("gemini://user:password@example.org"),
Err: ErrInvalidURL,
},
{
Req: newRequest("https://user:password@example.org"),
Err: ErrInvalidURL,
},
} }
for _, test := range tests { for _, test := range tests {