This commit is a follow-up to 56774408 which does not take into account
the case that the parent directory of the known_hosts file does not already exist.
This commit introduces the KnownHosts struct, whose purpose is simply to
store known hosts entries. The HostWriter struct is now in charge of
appending hosts to files, and the two are not dependent on each other.
Users are now responsible for opening the known hosts file and closing
it when they are finished with it.
This commit changes underlying file handling and known hosts parsing.
A known hosts file opened through Load() never closed the underlying
file. During known hosts parsing most errors were unchecked, or just
led to the line being skipped.
I removed the KnownHosts type, which didn't really have a role after
the refactor. The embedding of KnownHosts in KnownHosts file has been
removed as it also leaked the map unprotected by the mutex.
The Fingerprint type is now KnownHost and has taken over the
responsibility of marshalling and unmarshalling.
SetOutput now takes a WriteCloser so that we can close the underlying
writer when it's replaced, or when it's explicitly closed through the
new Close() function.
KnownHostsFile.Add() now also writes the known host to the output if
set. I think that makes sense expectation-wise for the type.
Turned WriteAll() into WriteTo() to conform with the io.WriterTo
interface.
Load() is now Open() to better reflect the fact that a file is opened,
and kept open. It can now also return errors from the parsing process.
The parser does a lot more error checking, and this might be an area
where I've changed a desired behaviour as invalid entries no longer
are ignored, but aborts the parsing process. That could be changed to
a warning, or some kind of parsing feedback.
I added KnownHostsFile.TOFU() to fill the developer experience gap
that was left after the client no longer knows about
KnownHostsFile. It implements a basic non-interactive TOFU flow.
Adnan Maolood
Noah Kleiner
Hugo Wetterberg