make-containers-better #10

Merged

sashakoshka merged 20 commits from make-containers-better into main 2023-03-04 14:26:34 -07:00

Conversation 0 Commits 20 Files Changed 10

+514 -339

sashakoshka commented 2023-03-04 14:26:22 -07:00

Owner

Copy Link

Copy Source

No description provided.

sashakoshka added 20 commits 2023-03-04 14:26:23 -07:00

Remove margin from layout interface ... 285cb4810f

Layouts will need to store margin and padding values within
themseleves.

Added padding/margin distinction to layouts e9e6e4fbe7

ContainerCore and ContainerCoreControl WIP 38baa97e76

No that was a bad idea time to do something else 538123dcd5

Created the stub for Propagator ... 6bb5b2d79c

Unlike the previous poorly-defined ContainerCore idea, this struct
has one sole responsibility and that is propagating events to
children. There may be another struct called like ChildManager or
something in the future that also abstracts away logic for
adoption, canvas cutting, disowning, layout, etc.

Tidied up documentation on Propagator b6eb158964

Implemented keyboard, mouse, theme, and config event propagation 5af8d7fd97

Implemented all focus methods except for HandleFocus ... c13cdd570d

I am dreading this

Fully implemented Propagator 1d9fb6024d

Cleaned up the (ChildIterator -> Parent) interface 56e11ae1de

Worked Propagator into basic.Container 165d0835bf

Cleaned up Container somewhat 252433f13d

The container actually creates a propagator now lmao be286fa86c

Fixed Propagator.forChildren 90ce0d7281

Layouts now take in proper margin and padding values 5fc5af92df

Propagator no longer segfaults when handling keynav dc5ddfc0bd

Me when I make the exact mistake twice 4f6f4e1f1a

Fixed cringe bug with focus requests being improperly handled 9c12cd7e18

Fixed Container not clearing child event handlers in DisownAll 531b0ffce9

oops lmao 912a3f9f66

sashakoshka merged commit cad10a1fb1 into main 2023-03-04 14:26:34 -07:00

sashakoshka deleted branch make-containers-better 2023-03-04 14:26:34 -07:00

sashakoshka referenced this issue from a commit 2023-03-04 14:26:34 -07:00

Merge pull request 'make-containers-better' (#10) from make-containers-better into main

This repo is archived. You cannot comment on pull requests.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

sashakoshka (Sasha Koshka)

No Assignees

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: tomo/tomo-old#10