Fix TextBox scroll behavior

containerbox.go

@@ -59,7 +59,7 @@ func (this *containerBox) ContentBounds () image.Rectangle {
 }
 
 func (this *containerBox) ScrollTo (point image.Point) {
-	// TODO: constrain scroll
+	if this.scroll == point { return }
 	this.scroll = point
 	this.invalidateLayout()
 }
@@ -119,10 +119,14 @@ func (this *containerBox) Insert (child, before tomo.Object) {
 
 	beforeBox := assertAnyBox(before.GetBox())
 	index     := indexOf(this.children, tomo.Box(beforeBox))
-	if index < 0 { return }
 	
-	box.setParent(this)
+	if index < 0 {
+		this.children = append(this.children, tomo.Box(box))
+	} else {
 		this.children = insert(this.children, index, tomo.Box(box))
+	}
+	box.setParent(this)
+
 	this.invalidateLayout()
 	this.invalidateMinimum()
 }
@@ -221,10 +225,14 @@ func (this *containerBox) notifyMinimumSizeChange (child anyBox) {
 	}
 }
 
+func (this *containerBox) boundedLayoutHints () tomo.LayoutHints {
+	hints := this.layoutHints()
+	hints.Bounds = this.ContentBounds().Add(this.InnerBounds().Min)
+	return hints
+}
+
 func (this *containerBox) layoutHints () tomo.LayoutHints {
-	innerBounds := this.InnerBounds().Sub(this.scroll)
 	return tomo.LayoutHints {
-		Bounds:    innerBounds,
 		OverflowX: this.hOverflow,
 		OverflowY: this.vOverflow,
 		AlignX:    this.hAlign,
@@ -236,10 +244,12 @@ func (this *containerBox) layoutHints () tomo.LayoutHints {
 func (this *containerBox) contentMinimum () image.Point {
 	minimum := this.box.contentMinimum()
 	if this.layout != nil {
-		minimum = minimum.Add (
-			this.layout.MinimumSize (
-				this.layoutHints(),
-				this.children))
+		layoutMinimum := this.layout.MinimumSize (
+			this.boundedLayoutHints(),
+			this.children)
+		if this.hOverflow { layoutMinimum.X = 0 }
+		if this.vOverflow { layoutMinimum.Y = 0 }
+		minimum = minimum.Add(layoutMinimum)
 	}
 	return minimum
 }
@@ -247,14 +257,59 @@ func (this *containerBox) contentMinimum () image.Point {
 func (this *containerBox) doLayout () {
 	this.box.doLayout()
 	previousContentBounds := this.contentBounds
+
+	// by default, use innerBounds for contentBounds. if a direction
+	// overflows, use the layout's minimum size for it.
+	var minimum image.Point
 	if this.layout != nil {
-		this.layout.Arrange(this.layoutHints(), this.children)
+		minimum = this.layout.MinimumSize (
+			this.layoutHints(),
+			this.children)
 	}
+	innerBounds := this.InnerBounds()
+	this.contentBounds = innerBounds
+	if this.hOverflow { this.contentBounds.Max.X = this.contentBounds.Min.X + minimum.X }
+	if this.vOverflow { this.contentBounds.Max.Y = this.contentBounds.Min.Y + minimum.Y }
+
+	// offset the content bounds by the scroll so children can be positioned
+	// accordingly.
+	this.constrainScroll()
+	this.contentBounds = this.contentBounds.Add(this.scroll).Sub(innerBounds.Min)
+	
+	// arrange children
+	if this.layout != nil {
+		this.layout.Arrange(this.boundedLayoutHints(), this.children)
+	}
+	
 	if previousContentBounds != this.contentBounds {
 		this.on.contentBoundsChange.Broadcast()
 	}
 }
 
+func (this *containerBox) constrainScroll () {
+	innerBounds := this.InnerBounds()
+	width  := this.contentBounds.Dx()
+	height := this.contentBounds.Dy()
+
+	// X
+	if width <= innerBounds.Dx() {
+		this.scroll.X = 0
+	} else if this.scroll.X > 0 {
+		this.scroll.X = 0
+	} else if this.scroll.X < innerBounds.Dx() - width  {
+		this.scroll.X =  innerBounds.Dx() - width
+	}
+
+	// Y
+	if height <= innerBounds.Dy() {
+		this.scroll.Y = 0
+	} else if this.scroll.Y > 0 {
+		this.scroll.Y = 0
+	} else if this.scroll.Y < innerBounds.Dy() - height {
+		this.scroll.Y = innerBounds.Dy() - height
+	}
+}
+
 func (this *containerBox) recursiveRedo () {
 	this.doLayout()
 	this.doDraw()

event.go

@@ -339,13 +339,15 @@ func (window *window) handleMotionNotify (
 	}
 
 	underneath := window.boxUnder(image.Pt(x, y), eventCategoryMouse)
+	if underneath != nil {
 		window.hover(underneath)
-	
 		if !handled {
 			underneath.handleMouseMove()
 		}
 	}
 	
+}
+
 func (window *window) compressExpose (
 	firstEvent xproto.ExposeEvent,
 ) (

go.mod

@@ -3,8 +3,8 @@ module git.tebibyte.media/tomo/x
 go 1.20
 
 require (
-	git.tebibyte.media/tomo/tomo v0.29.0
-	git.tebibyte.media/tomo/typeset v0.7.0
+	git.tebibyte.media/tomo/tomo v0.31.0
+	git.tebibyte.media/tomo/typeset v0.7.1
 	git.tebibyte.media/tomo/xgbkb v1.0.1
 	github.com/jezek/xgb v1.1.0
 	github.com/jezek/xgbutil v0.0.0-20230603163917-04188eb39cf0

go.sum

@@ -1,8 +1,8 @@
 git.tebibyte.media/sashakoshka/xgbkb v1.0.0/go.mod h1:pNcE6TRO93vHd6q42SdwLSTTj25L0Yzggz7yLe0JV6Q=
-git.tebibyte.media/tomo/tomo v0.29.0 h1:uvdPaEQYcWH965y85SjIKwhLklnTbs+x6MRwLfdRvfo=
-git.tebibyte.media/tomo/tomo v0.29.0/go.mod h1:C9EzepS9wjkTJjnZaPBh22YvVPyA4hbBAJVU20Rdmps=
-git.tebibyte.media/tomo/typeset v0.7.0 h1:JFpEuGmN6R2XSCvkINYxpH0AyYUqqs+dZYr6OSd91y0=
-git.tebibyte.media/tomo/typeset v0.7.0/go.mod h1:PwDpSdBF3l/EzoIsa2ME7QffVVajnTHZN6l3MHEGe1g=
+git.tebibyte.media/tomo/tomo v0.31.0 h1:LHPpj3AWycochnC8F441aaRNS6Tq6w6WnBrp/LGjyhM=
+git.tebibyte.media/tomo/tomo v0.31.0/go.mod h1:C9EzepS9wjkTJjnZaPBh22YvVPyA4hbBAJVU20Rdmps=
+git.tebibyte.media/tomo/typeset v0.7.1 h1:aZrsHwCG5ZB4f5CruRFsxLv5ezJUCFUFsQJJso2sXQ8=
+git.tebibyte.media/tomo/typeset v0.7.1/go.mod h1:PwDpSdBF3l/EzoIsa2ME7QffVVajnTHZN6l3MHEGe1g=
 git.tebibyte.media/tomo/xgbkb v1.0.1 h1:b3HDUopjdQp1MZrb5Vpil4bOtk3NnNXtfQW27Blw2kE=
 git.tebibyte.media/tomo/xgbkb v1.0.1/go.mod h1:P5Du0yo5hUsojchW08t+Mds0XPIJXwMi733ZfklzjRw=
 github.com/BurntSushi/freetype-go v0.0.0-20160129220410-b763ddbfe298 h1:1qlsVAQJXZHsaM8b6OLVo6muQUQd4CwkH/D3fnnbHXA=

textbox.go

@@ -222,7 +222,7 @@ func (this *textBox) drawDot (can canvas.Canvas) {
 
 func (this *textBox) textOffset () image.Point {
 	return this.InnerBounds().Min.
-		Sub(this.scroll).
+		Add(this.scroll).
 		Sub(this.drawer.LayoutBoundsSpace().Min)
 }
 
@@ -294,6 +294,7 @@ func (this *textBox) doLayout () {
 	this.contentBounds = this.normalizedLayoutBoundsSpace()
 	this.constrainScroll()
 	this.contentBounds = this.contentBounds.Add(this.scroll)
+	// println(this.InnerBounds().String(), this.contentBounds.String())
 
 	if previousContentBounds != this.contentBounds {
 		this.on.contentBoundsChange.Broadcast()
@@ -308,19 +309,19 @@ func (this *textBox) constrainScroll () {
 	// X
 	if width <= innerBounds.Dx() {
 		this.scroll.X = 0
-	} else if this.scroll.X < 0 {
+	} else if this.scroll.X > 0 {
 		this.scroll.X = 0
-	} else if this.scroll.X > width - innerBounds.Dx() {
-		this.scroll.X = width - innerBounds.Dx()
+	} else if this.scroll.X < innerBounds.Dx() - width  {
+		this.scroll.X =  innerBounds.Dx() - width
 	}
 
 	// Y
 	if height <= innerBounds.Dy() {
 		this.scroll.Y = 0
-	} else if this.scroll.Y < 0 {
+	} else if this.scroll.Y > 0 {
 		this.scroll.Y = 0
-	} else if this.scroll.Y > height - innerBounds.Dy() {
-		this.scroll.Y = height - innerBounds.Dy()
+	} else if this.scroll.Y < innerBounds.Dy() - height {
+		this.scroll.Y = innerBounds.Dy() - height
 	}
 }
 
@@ -333,16 +334,16 @@ func (this *textBox) scrollToDot () {
 
 	// X
 	if dot.X < innerBounds.Min.X + em {
-		scroll.X -= innerBounds.Min.X - dot.X + em
+		scroll.X += innerBounds.Min.X - dot.X + em
 	} else if dot.X > innerBounds.Max.X - em {
-		scroll.X += dot.X - innerBounds.Max.X + em
+		scroll.X -= dot.X - innerBounds.Max.X + em
 	}
 
 	// Y
 	if dot.Y < innerBounds.Min.Y + lineHeight {
-		scroll.Y -= innerBounds.Min.Y - dot.Y + lineHeight
+		scroll.Y += innerBounds.Min.Y - dot.Y + lineHeight
 	} else if dot.Y > innerBounds.Max.Y - lineHeight {
-		scroll.Y += dot.Y - innerBounds.Max.Y + lineHeight
+		scroll.Y -= dot.Y - innerBounds.Max.Y + lineHeight
 	}
 	
 	this.ScrollTo(scroll)

x/plugin.go

@@ -1,17 +0,0 @@
-// Plugin x provides the X11 backend as a plugin.
-package main
-
-import "git.tebibyte.media/tomo/x"
-import "git.tebibyte.media/tomo/tomo"
-
-func init () {
-	tomo.Register(0, tomo.Factory(x.NewBackend))	
-}
-
-func Name () string {
-	return "X"
-}
-
-func Description () string {
-	return "Provides an X11 backend."
-}