bonsai/harakit
5
4
Fork 3
Code Issues 42 Pull Requests 5 Projects 1 Releases 34 Activity

Makefile: updates to use new POSIX 2024 standard features! #121

Closed
emma wants to merge 0 commits from makefile-posix-2024 into main
pull from: makefile-posix-2024
merge into: bonsai:main
Conversation 1 Commits - Files Changed -
emma commented 2024-06-18 16:34:12 -06:00
Owner
Copy Link
No description provided.
emma added the
enhancement
 label 2024-06-18 16:34:12 -06:00
emma self-assigned this 2024-06-18 16:34:13 -06:00
emma added 2 commits 2024-06-18 16:34:13 -06:00
emma requested review from trinity 2024-06-18 16:34:17 -06:00
emma requested review from silt 2024-06-18 16:34:17 -06:00
trinity approved these changes 2024-06-19 22:45:39 -06:00
trinity left a comment
Owner
Copy Link

Otherwise well done as always.

Otherwise well done as always.
Makefile Outdated
@ -70,3 +67,2 @@
build/o/libsysexits.rlib: build $(SYSEXITS)sysexits.h
# bandage solution until bindgen(1) gets stdin support
printf '#define EXIT_FAILURE 1\n' | cat - $(SYSEXITS)sysexits.h \
printf '\043define EXIT_FAILURE 1\n' | cat - $(SYSEXITS)sysexits.h \
trinity commented 2024-06-19 22:45:25 -06:00
Owner
Copy Link

You should add a comment saying why the octal is necessary.

You should add a comment saying why the octal is necessary.
emma added 1 commit 2024-06-19 23:30:20 -06:00
emma closed this pull request 2024-06-19 23:30:36 -06:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
silt
trinity
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
joke
you are silly!
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
emma nitori silt trinity
No Assignees emma
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonsai/harakit#121
No description provided.
Delete Branch "makefile-posix-2024"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?