dj(1): Refactor source a bit, remove -Adq #125

2024-06-26T15:42:14-06:00

trinity commented

2024-06-26 15:42:14 -06:00

dj -A has been replaced with dj -a "\0" or the more brief dj -a ''.
dj -d was mostly necessary for debugging number parsing and putting it in an option rather than a compilation flag, while seemingly sensible at the time, is something I now regret.
dj -q can be replaced with something like dj -o /dev/null 2>&1 | grep -ve '^\t' -e 'Partial'.

These changes have also been made in the man page.

Additionally, I reworked the program to use more sensible scoping for variables (no more globals, except static allocations) and fixed some functions to make more sense in usage.

- `dj -A` has been replaced with `dj -a "\0"` or the more brief `dj -a ''`. - `dj -d` was mostly necessary for debugging number parsing and putting it in an option rather than a compilation flag, while seemingly sensible at the time, is something I now regret. - `dj -q` can be replaced with something like `dj -o /dev/null 2>&1 | grep -ve '^\t' -e 'Partial'`. These changes have also been made in the man page. Additionally, I reworked the program to use more sensible scoping for variables (no more globals, except static allocations) and fixed some functions to make more sense in usage.

trinity added the enhancement label 2024-06-26 15:42:14 -06:00

trinity added 9 commits 2024-06-26 15:42:15 -06:00

dj(1), dj.1: remove the unnecessary -d and -q d3f5246242

dj(1): fix usage text to be consistent with man page 95f7992e0f

dj(1): refactor to build again and to get rid of globals 45a880455d

dj(1): refactor Io_fdseek 66f5498232

dj(1): remove Io_buffree b70b356ce5

dj(1): more refactor (get rid of ep pun) e65f6b650d

dj(1), dj.1: Remove -A (use -a "\0") (see #101 ) fb74e7bef0

dj(1): refactor (remove Io_setdefaults and other stuff) 2cfae0e8d7

dj(1): more refactor (get rid of the c scratch variable, use scoping) 3a66022c6d

emma reviewed 2024-06-26 15:47:04 -06:00

docs/dj.1 Outdated

						
				@@ -104,3 +92,1 @@

				.B -q

				option is specified, a diagnostic message is printed. Then, the program exits

				unless the

				On a partial or empty read a diagnostic message is printed. Then, the program

emma commented

2024-06-26 15:47:04 -06:00

On a partial or empty read, a diagnostic message [...]

> On a partial or empty read, a diagnostic message [...]

emma marked this conversation as resolved

emma reviewed 2024-06-26 15:49:20 -06:00

docs/dj.1

						
				@@ -11,7 +11,7 @@ dj \(en disk jockey

				.SH SYNOPSIS

emma commented

2024-06-26 15:49:20 -06:00

If you update the manpage, update the date to the date when you updated it.

emma marked this conversation as resolved

emma reviewed 2024-06-26 15:55:10 -06:00

docs/dj.1 Outdated

						
				@@ -81,4 +75,2 @@

				DIAGNOSTICS section. Each invocation increments the debug level of the

				program.

				.IP \fB-H\fP

				Prints diagnostics messages in a human-readable manner as described in the

emma commented

2024-06-26 15:55:10 -06:00

This isn’t a change made here but this should say “diagnostic message” because it is an adjective and because it would be in line with the rest of the manpage.

emma marked this conversation as resolved

trinity changed title from ~~WIP: dj(1): Refactor source a bit, remove -adq~~ to WIP: dj(1): Refactor source a bit, remove -Adq

2024-06-27 05:59:12 -06:00

trinity referenced this pull request

2024-06-27 06:09:31 -06:00

dj(1) null-byte padding: `-A` or `-a ''`? #101

trinity added 1 commit 2024-06-29 05:55:42 -06:00

dj.1: Man page fixes 67b60e20cc

trinity added 1 commit 2024-06-29 05:56:45 -06:00

Merge branch 'main' into dj 3b5ddede98

trinity marked the pull request as ready for review 2024-06-29 05:57:01 -06:00

trinity requested review from emma 2024-06-29 05:57:09 -06:00