bonsai/harakit
5
4
Fork 3
Code Issues 42 Pull Requests 5 Projects 1 Releases 34 Activity

docs: fixes and clarification #128

Closed
Ghost wants to merge 3 commits from (deleted):main into main
pull from: (deleted):main
merge into: bonsai:main
Conversation 2 Commits 3 Files Changed 5 +15 -11
Ghost commented 2024-06-27 12:47:21 -06:00
First-time contributor
Copy Link

'file' is better than 'path' here because a file is the object and a commonplace term.
top/bottom are more common when talking about stacks
suid/guid hyphenated to clarify that it is one concept.

'file' is better than 'path' here because a file is the object and a commonplace term. top/bottom are more common when talking about stacks suid/guid hyphenated to clarify that it is one concept.
Ghost added 1 commit 2024-06-27 12:47:22 -06:00
emma requested changes 2024-06-27 13:57:09 -06:00
docs/rpn.1 Outdated
@ -25,3 +25,1 @@
Upon evaluation, the resulting number on the stack will be printed to the
standard output. Any further numbers specified will be placed at the end of the
stack.
Upon evaluation, the resulting number on the top of the stack will be printed
emma commented 2024-06-27 13:54:03 -06:00
Owner
Copy Link

Would this work better as “at the top of the stack”?

Would this work better as “at the top of the stack”?
Ghost commented 2024-06-27 20:45:33 -06:00
Author
First-time contributor
Copy Link

haha that's embarrassing, fixed in new commit.

haha that's embarrassing, fixed in new commit.
Ghost marked this conversation as resolved
docs/scrut.1 Outdated
@ -37,3 +37,3 @@
Requires the given files to exist and be regular files.
.IP \fB-g\fP
Requires the given files to exist and have their set group ID flags set.
Requires the given files to exist and have their set-group-ID flags set.
emma commented 2024-06-27 13:56:30 -06:00
Owner
Copy Link

Are these changes the proper terminology? Wikipedia differs from this: https://en.wikipedia.org/wiki/Setuid

Are these changes the proper terminology? Wikipedia differs from this: https://en.wikipedia.org/wiki/Setuid
Ghost commented 2024-06-27 20:45:52 -06:00
Author
First-time contributor
Copy Link

changed in new commit.

changed in new commit.
Ghost marked this conversation as resolved
docs/scrut.1 Outdated
@ -40,2 +39,3 @@
Requires the given files to exist and have their set-group-ID flags set.
.IP \fB-k\fP
Requires the given files to exist and have their sticky bit set.
Requires the given files to exist and have their sticky flags set.
emma commented 2024-06-27 13:57:01 -06:00
Owner
Copy Link

Same for this: https://en.wikipedia.org/wiki/Sticky_bit

Same for this: https://en.wikipedia.org/wiki/Sticky_bit
Ghost commented 2024-06-27 20:46:00 -06:00
Author
First-time contributor
Copy Link

changed in new commit.

changed in new commit.
Ghost marked this conversation as resolved
emma commented 2024-06-27 13:59:40 -06:00
Owner
Copy Link

Please also add your copyright information to the header as per the CONTRIBUTING file.

Please also add your copyright information to the header as per the `CONTRIBUTING` file.
Ghost added 1 commit 2024-06-27 20:42:37 -06:00
Ghost changed title from manpage fixes to docs: fixes and clarification 2024-06-27 20:43:17 -06:00
Ghost added 1 commit 2024-06-28 00:14:41 -06:00
Ghost closed this pull request 2024-06-28 00:38:21 -06:00
trinity commented 2024-06-28 08:55:40 -06:00
Owner
Copy Link

Many of these fixes would be welcome. May I ask why this was closed?

Many of these fixes would be welcome. May I ask why this was closed?

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
emma
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
joke

you are silly!

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
joke
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: bonsai/harakit#128
No description provided.
Delete Branch "(deleted):main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?