bonsai/harakit
5
4
Fork 3
Code Issues 43 Pull Requests 3 Projects 1 Releases 36 Activity

Makefile improvements #151

Closed
emma wants to merge 0 commits from makefile-changes into main
pull from: makefile-changes
merge into: bonsai:main
Conversation 5 Commits - Files Changed -
emma commented 2024-08-01 00:08:00 -06:00
Owner
Copy Link

Some changes to make the Makefile a little better.

Some changes to make the Makefile a little better.
emma added the
enhancement
 label 2024-08-01 00:08:00 -06:00
emma added 2 commits 2024-08-01 00:08:00 -06:00
Makefile: uses dirname(1) to get normalized prefix, adds libraries to RUSTFLAGS, fixes typo 4aeba9d13f
Makefile: changes test usage 18aac06113
emma requested review from trinity 2024-08-01 00:08:36 -06:00
emma requested review from silt 2024-08-01 00:08:36 -06:00
trinity reviewed 2024-08-01 06:30:55 -06:00
Makefile Outdated
@@ -21,2 +20,2 @@
&& CDPATH= cd -P -- $(PREFIX) && pwd -P)
MANDIR != [ $(PREFIX_N) = / ] && printf '/usr/share/man\n' \
PREFIX_N != dirname $(PREFIX)/.
MANDIR != test $(PREFIX_N) -eq / && printf '/usr/share/man\n' \
trinity commented 2024-08-01 06:30:55 -06:00
Owner
Copy Link

-eq is integer equality, identical to intcmp -e. You'll want to use an equality sign instead.

-eq is integer equality, identical to intcmp -e. You'll want to use an equality sign instead.
trinity marked this conversation as resolved
trinity reviewed 2024-08-01 06:33:33 -06:00
Makefile
@@ -27,3 +26,3 @@
CC ?= cc
RUSTC ?= rustc
RUSTLIBS = --extern getopt=build/o/libgetopt.rlib \
RUSTFLAGS += --extern getopt=build/o/libgetopt.rlib \
trinity commented 2024-08-01 06:33:33 -06:00
Owner
Copy Link

Should this be renamed elsewhere too?

Should this be renamed elsewhere too?
trinity marked this conversation as resolved
trinity commented 2024-08-01 10:50:59 -06:00
Owner
Copy Link

These are good changes. I'll approve them once I know they work.

These are good changes. I'll approve them once I know they work.
emma added 1 commit 2024-08-01 13:13:15 -06:00
Makefile: fixes test and removes references to the RUSTLIBS variable 0b0bd9bd76
trinity approved these changes 2024-08-01 19:30:36 -06:00
emma commented 2024-08-01 20:30:15 -06:00
Author
Owner
Copy Link

Merged.

Merged.
emma closed this pull request 2024-08-01 20:30:15 -06:00
emma deleted branch makefile-changes 2024-08-01 20:30:20 -06:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
silt
trinity
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
joke
you are silly!
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
emma nitori silt soup trinity
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonsai/harakit#151
No description provided.
Delete Branch "makefile-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?