bonsai/harakit
4
4
Fork 3
Code Issues 39 Pull Requests 3 Projects 1 Releases 36 Activity

STYLE: make rules more granular and consistent, add examples #156

Closed
trinity wants to merge 0 commits from style-c into main
pull from: style-c
merge into: bonsai:main
Conversation 5 Commits - Files Changed -
trinity commented 2024-08-08 02:33:01 -06:00
Owner
Copy Link
No description provided.
trinity added the
enhancement
 label 2024-08-08 02:33:01 -06:00
trinity added 1 commit 2024-08-08 02:33:01 -06:00
trinity requested review from emma 2024-08-08 02:33:09 -06:00
trinity reviewed 2024-08-08 02:33:50 -06:00
STYLE Outdated
@ -112,0 +119,4 @@
1. Avoid:
- function pointers; see [0].
- heap memory allocation; see [0].
- too many levels of dereferences; see [0].
trinity commented 2024-08-08 02:33:50 -06:00
Author
Owner
Copy Link

I struggled with coming up with this example. Could someone proofread this?

I struggled with coming up with this example. Could someone proofread this?
trinity marked this conversation as resolved
emma added 1 commit 2024-09-05 12:44:23 -06:00
emma commented 2024-09-05 13:41:24 -06:00
Owner
Copy Link

I made changes to allow simple citation of the guidelines and clarify some of the visual hierarchy of the document.

I made changes to allow simple citation of the guidelines and clarify some of the visual hierarchy of the document.
emma added 1 commit 2024-09-05 15:55:51 -06:00
emma added 1 commit 2024-09-07 12:51:32 -06:00
trinity reviewed 2024-09-09 07:36:32 -06:00
STYLE Outdated
@ -9,0 +31,4 @@
case possibility:
statement;
break;
case default:
trinity commented 2024-09-09 07:36:32 -06:00
Author
Owner
Copy Link

This should just be default: (so, sed 34s:case ::); as-is this is a syntax error.

This should just be `default:` (so, `sed 34s:case ::`); as-is this is a syntax error.
emma marked this conversation as resolved
trinity reviewed 2024-09-09 07:37:44 -06:00
STYLE Outdated
@ -34,3 +71,1 @@
case 'l': mode |= LESS; break;
default: return usage(s);
}
5. Fixed bounds for loops [0].
trinity commented 2024-09-09 07:37:44 -06:00
Author
Owner
Copy Link

I fear this is impossible; dj(1), for instance, necessarily can't put an upward bound on read cycles.

I fear this is impossible; dj(1), for instance, necessarily can't put an upward bound on read cycles.
trinity commented 2024-09-09 07:38:47 -06:00
Author
Owner
Copy Link

Maybe, "where possible"?

Maybe, "where possible"?
emma marked this conversation as resolved
emma added 1 commit 2024-09-10 02:00:18 -06:00
emma added 1 commit 2024-09-10 02:05:05 -06:00
emma closed this pull request 2025-02-24 23:04:04 -07:00
emma commented 2025-02-24 23:05:33 -07:00
Owner
Copy Link

Merged.

Merged.
emma deleted branch style-c 2025-02-24 23:06:26 -07:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
emma
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
joke
you are silly!
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
emma nitori silt trinity
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonsai/harakit#156
No description provided.
Delete Branch "style-c"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?