linux-fix #159

Closed
emma wants to merge 0 commits from linux-fix into main
Owner
No description provided.
emma added the
bug
label 2024-08-17 02:02:38 -06:00
emma added 2 commits 2024-08-17 02:02:38 -06:00
Author
Owner

@trinity: The npc(1) tests fail thusly:

$ pdpmake npc_tests
! build/bin/npc -h
build/bin/npc: invalid option -- 'h'
Usage: build/bin/npc [-et]
build/bin/npc -e </dev/null
build/bin/npc -t </dev/null
build/bin/npc -et </dev/null
! build/bin/npc -et 5 </dev/null
Usage: build/bin/npc [-et]
# ASCII 0x00 to 0x0a (before the newline, due to xargs(1p) issues)
awk 'BEGIN{ for (i = 0; i < 32; ++i) printf("%c", i); }' \
	| build/bin/npc \
	| head -n 1 \
	| xargs -I out test "^@^A^B^C^D^E^F^G^H" = out
pdpmake: (tests/bonsai/npc.mk:39): failed to build 'npc_ascii_controls' exit 123

I do not understand this test, please help me out with this.

@trinity: The `npc(1)` tests fail thusly: ```sh $ pdpmake npc_tests ! build/bin/npc -h build/bin/npc: invalid option -- 'h' Usage: build/bin/npc [-et] build/bin/npc -e </dev/null build/bin/npc -t </dev/null build/bin/npc -et </dev/null ! build/bin/npc -et 5 </dev/null Usage: build/bin/npc [-et] # ASCII 0x00 to 0x0a (before the newline, due to xargs(1p) issues) awk 'BEGIN{ for (i = 0; i < 32; ++i) printf("%c", i); }' \ | build/bin/npc \ | head -n 1 \ | xargs -I out test "^@^A^B^C^D^E^F^G^H" = out pdpmake: (tests/bonsai/npc.mk:39): failed to build 'npc_ascii_controls' exit 123 ``` I do not understand this test, please help me out with this.
Author
Owner

(This is on Artix Linux running the latest GNU coreutils)

(This is on Artix Linux running the latest GNU coreutils)
trinity reviewed 2024-08-19 19:03:51 -06:00
@ -20,3 +20,3 @@
case "$$(uname)" in \
Linux) \
$(BIN)/dj -Hi /dev/zero -o /dev/full 2>&1 \
! $(BIN)/dj -Hi /dev/zero -o /dev/full 2>&1 \
Owner

Could you please explain this change?

Could you please explain this change?
Author
Owner

Writing into /dev/full exits unsuccessfully because writing data to /dev/full always fails and sets errno to ENOSPC.

Writing into `/dev/full` exits unsuccessfully because writing data to `/dev/full` always fails and sets `errno` to `ENOSPC`.
Author
Owner

@trinity verbally confirmed that it understood this change.

@trinity verbally confirmed that it understood this change.
Owner

Indeed.

Indeed.
emma marked this conversation as resolved
emma requested review from trinity 2024-08-21 20:47:47 -06:00
trinity added 1 commit 2024-08-21 21:57:54 -06:00
trinity added 1 commit 2024-08-21 21:59:28 -06:00
trinity approved these changes 2024-08-21 22:00:35 -06:00
Owner

I haven't fully tested this on Linux but am confident it will work.

I haven't fully tested this on Linux but am confident it will work.
Author
Owner

Merged.

Merged.
emma closed this pull request 2024-08-21 22:44:39 -06:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: bonsai/harakit#159
No description provided.