bonsai/harakit
4
4
Fork 3
Code Issues 41 Pull Requests 2 Projects 1 Releases 35 Activity

CONTRIBUTING: merge STYLE into contents #168

Closed
emma wants to merge 2 commits from contributing-style-merge into main
pull from: contributing-style-merge
merge into: bonsai:main
Conversation 6 Commits 2 Files Changed 3 +255 -267
emma commented 2025-04-03 16:48:31 -06:00
Owner
Copy Link
No description provided.
emma added the
enhancement
 label 2025-04-03 16:48:31 -06:00
emma self-assigned this 2025-04-03 16:48:32 -06:00
emma added 2 commits 2025-04-03 16:48:34 -06:00
emma requested review from trinity 2025-04-03 16:49:10 -06:00
emma requested review from silt 2025-04-03 16:49:17 -06:00
silt commented 2025-04-04 13:47:14 -06:00
Owner
Copy Link

i don't agree with the decision to merge these two documents. it is true that they're related, but they present distinct enough information (and exist at different enough stages of the development process) to warrant keeping them separate.

i don't agree with the decision to merge these two documents. it is true that they're related, but they present distinct enough information (and exist at different enough stages of the development process) to warrant keeping them separate.
emma commented 2025-04-04 13:51:54 -06:00
Author
Owner
Copy Link

@silt: where is the line between CONTRIBUTING and STYLE?

@silt: where is the line between CONTRIBUTING and STYLE?
silt commented 2025-04-04 14:07:30 -06:00
Owner
Copy Link

the latter concerns itself with matters of code formatting and convention, and the former everything else

the latter concerns itself with matters of code formatting and convention, and the former everything else
trinity reviewed 2025-04-05 06:37:14 -06:00
trinity left a comment
Owner
Copy Link

Looks good to me. I agree with this change.

Looks good to me. I agree with this change.
trinity commented 2025-04-05 06:41:28 -06:00
Owner
Copy Link

I think style falls under the CONTRIBUTING umbrella nicely; it's one little handbook that tells you how to participate in the project, from the forest to the trees.

I think style falls under the `CONTRIBUTING` umbrella nicely; it's one little handbook that tells you how to participate in the project, from the forest to the trees.
emma closed this pull request 2025-10-13 22:02:37 -06:00
emma commented 2025-10-26 17:06:10 -06:00
Author
Owner
Copy Link

Merged.

Merged.
emma removed review request for silt 2025-10-26 17:06:36 -06:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
joke
you are silly!
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
emma nitori silt trinity
No Assignees emma
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonsai/harakit#168
No description provided.
Delete Branch "contributing-style-merge"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?