> *@trinity* commented on this pull request.
>
> I have some questions about certain changes.
>
> In src/dj.c:
> diff --git a/src/dj.c b/src/dj.c
> --- a/src/dj.c
> +++ b/src/dj.c
> @@ -286,2 +287,3 @@
> /* easy seeking */
> - if (!fdisstd(io[i].fd) && lseek(io[i].fd, io[i].seek, SEEK_SET) != -1)
> {
> + if (!fdisstd(io[i].fd) && lseek(io[i].fd, io[i].seek, SEEK_SET) != -1)
> + {
>
> Could you explain this change?
The line did not fit within 80 columns and there was no other good place
to break it.
> In docs/mm.1:
> diff --git a/docs/mm.1 b/docs/mm.1
> --- a/docs/mm.1
> +++ b/docs/mm.1
> @@ -64,0 +74,4 @@
> +.MT trinity@trinity.moe
> +.ME .
> +.\"
> +.SH COPYRIGHT
>
> Why the second copyright?
Mistake.
So, the -a option is a switch meant to bitwise-or the open(2) mode argument with O_APPEND; this lack of truncation is what the kernel does, not what the program does. -a doesn't imply -t, but -t is inconsequential when -a is already set.
So, the `-a` option is a switch meant to bitwise-or the open(2) mode argument with `O_APPEND`; this lack of truncation is what the kernel does, not what the program does. `-a` doesn't imply `-t`, but `-t` is inconsequential when `-a` is already set.
This change actually fixes a bug, without it, the program exits
unsuccessfully. The problem is that if you have truncate as true (the
default behavior) and try to append, the Rust standard library returns
an error, which makes sense.
This change actually fixes a bug, without it, the program exits
unsuccessfully. The problem is that if you have truncate as true (the
default behavior) and try to append, the Rust standard library returns
an error, which makes sense.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
silt
trinity
I have some questions about certain changes.
@@ -64,0 +74,4 @@.MT trinity@trinity.moe.ME ..\".SH COPYRIGHTWhy the second copyright?
mistake
@@ -286,2 +287,3 @@/* easy seeking */if (!fdisstd(io[i].fd) && lseek(io[i].fd, io[i].seek, SEEK_SET) != -1) {if (!fdisstd(io[i].fd) && lseek(io[i].fd, io[i].seek, SEEK_SET) != -1){Could you explain this change?
The line did not fit within 80 columns and there was no other good place
to break it.
The line did not fit within 80 columns and there was no other good place
to break it.
Mistake.
@@ -24,1 +25,3 @@Opens outputs for appending rather than updating.Opens outputs for appending rather than updating. Implies the.B -toption.I don't remember this being the case, I'll have to double check.
So, the
-aoption is a switch meant to bitwise-or the open(2) mode argument withO_APPEND; this lack of truncation is what the kernel does, not what the program does.-adoesn't imply-t, but-tis inconsequential when-ais already set.This change actually fixes a bug, without it, the program exits
unsuccessfully. The problem is that if you have truncate as true (the
default behavior) and try to append, the Rust standard library returns
an error, which makes sense.
@@ -64,0 +71,4 @@.BR dj (1)utility\(cqs niche..\".SH AUTHOREmma Tebibyte should be credited here as the current in-tree mm(1) implementation was mostly faer work.
@@ -43,9 +44,6 @@ appended to the list of files to use as outputs..\".SH DIAGNOSTICSIt's better, functionality wise, to quit on errorful input before the error occurs.
Merged.
Pull request closed