bonsai/harakit
4
4
Fork 3
Code Issues 41 Pull Requests 2 Projects 1 Releases 35 Activity

WIP: libdelimiter #172

Draft
emma wants to merge 7 commits from libdelimiter into trunk
pull from: libdelimiter
merge into: bonsai:trunk
Conversation 5 Commits 7 Files Changed 4 +213 -74
emma commented 2025-10-29 16:21:59 -06:00
Owner
Copy Link
No description provided.
emma added the
enhancement
 label 2025-10-29 16:21:59 -06:00
emma self-assigned this 2025-10-29 16:22:01 -06:00
emma added 3 commits 2025-10-29 16:22:05 -06:00
emma requested review from silt 2025-10-29 16:22:20 -06:00
emma requested review from trinity 2025-10-29 16:22:24 -06:00
emma added 1 commit 2025-10-30 20:44:49 -06:00
silt reviewed 2025-10-30 22:21:42 -06:00
src/libdelimit.rs Outdated
@ -0,0 +18,4 @@
use std::{
io::{ Read, Result },
mem::self,
silt commented 2025-10-30 22:21:42 -06:00
Owner
Copy Link

self is unnecessary here and gets caught by rust-analyzer.

`self` is unnecessary here and gets caught by `rust-analyzer`.
silt marked this conversation as resolved
silt reviewed 2025-10-30 22:34:00 -06:00
src/libdelimit.rs Outdated
@ -0,0 +64,4 @@
},
Ok(n) => {
let content = &buf[..n];
self.buffer.extend_from_slice(&content);
silt commented 2025-10-30 22:34:00 -06:00
Owner
Copy Link

unnecessary to reference content which is itself already a reference

unnecessary to reference `content` which is itself already a reference
silt marked this conversation as resolved
silt commented 2025-10-30 22:41:19 -06:00
Owner
Copy Link

would recommend running format on it, there are a few random things here and there (including trailing whitespace and mixed spaces/tabs for indents)

would recommend running format on it, there are a few random things here and there (including trailing whitespace and mixed spaces/tabs for indents)
silt reviewed 2025-10-30 22:52:56 -06:00
src/libdelimit.rs
@ -0,0 +96,4 @@
#[test]
fn testing() {
let d = '\u{1E}'.to_string();
silt commented 2025-10-30 22:52:56 -06:00
Owner
Copy Link

.to_string() is unnecessary here as a Separator can be a char and .as_bytes is implemented for chars

`.to_string()` is unnecessary here as a `Separator` can be a `char` and `.as_bytes` is implemented for `char`s
silt commented 2025-10-30 23:41:16 -06:00
Owner
Copy Link

nevermind i am the biggest fool

nevermind i am the biggest fool
silt marked this conversation as resolved
emma added 1 commit 2025-10-30 23:29:59 -06:00
silt added 1 commit 2025-10-31 00:30:14 -06:00
silt force-pushed libdelimiter from ac467e26ce to c1df6e6322 2025-10-31 00:32:18 -06:00 Compare
emma added 1 commit 2025-10-31 00:58:31 -06:00
silt approved these changes 2025-10-31 11:37:46 -06:00
silt left a comment
Owner
Copy Link

looks fine to me now

looks fine to me now
This pull request is marked as a work in progress.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin libdelimiter:libdelimiter
git checkout libdelimiter
Sign in to join this conversation.
Reviewers
No Reviewers
trinity
silt
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
joke
you are silly!
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
emma nitori silt trinity
No Assignees emma
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonsai/harakit#172
No description provided.
Delete Branch "libdelimiter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?