libdelimiter
trunk
@@ -0,0 +18,4 @@
use std::{
io::{ Read, Result },
mem::self,
self is unnecessary here and gets caught by rust-analyzer.
self
rust-analyzer
@@ -0,0 +64,4 @@
},
Ok(n) => {
let content = &buf[..n];
self.buffer.extend_from_slice(&content);
unnecessary to reference content which is itself already a reference
content
would recommend running format on it, there are a few random things here and there (including trailing whitespace and mixed spaces/tabs for indents)
@@ -0,0 +96,4 @@
#[test]
fn testing() {
let d = '\u{1E}'.to_string();
.to_string() is unnecessary here as a Separator can be a char and .as_bytes is implemented for chars
.to_string()
Separator
char
.as_bytes
nevermind i am the biggest fool
ac467e26ce
c1df6e6322
looks fine to me now
Merged. Verbal approval was acquired from @trinity
No dependencies set.
The note is not visible to the blocked user.
silt
trinity
@@ -0,0 +18,4 @@use std::{io::{ Read, Result },mem::self,selfis unnecessary here and gets caught byrust-analyzer.@@ -0,0 +64,4 @@},Ok(n) => {let content = &buf[..n];self.buffer.extend_from_slice(&content);unnecessary to reference
contentwhich is itself already a referencewould recommend running format on it, there are a few random things here and there (including trailing whitespace and mixed spaces/tabs for indents)
@@ -0,0 +96,4 @@#[test]fn testing() {let d = '\u{1E}'.to_string();.to_string()is unnecessary here as aSeparatorcan be acharand.as_bytesis implemented forcharsnevermind i am the biggest fool
ac467e26cetoc1df6e6322looks fine to me now
Merged. Verbal approval was acquired from @trinity
Pull request closed