bonsai/harakit
5
4
Fork 3
Code Issues 42 Pull Requests Projects 1 Releases 34 Activity

CONTRIBUTING: updated information #52

Closed
emma wants to merge 0 commits from contributing-changes into main
pull from: contributing-changes
merge into: bonsai:main
Conversation 2 Commits - Files Changed -
emma commented 2024-02-07 22:04:21 -07:00
Owner
Copy Link
No description provided.
emma added the
enhancement
 label 2024-02-07 22:04:21 -07:00
emma self-assigned this 2024-02-07 22:04:21 -07:00
emma added 2 commits 2024-02-07 22:04:21 -07:00
emma requested review from trinity 2024-02-07 22:04:25 -07:00
emma requested review from silt 2024-02-07 22:04:25 -07:00
trinity requested changes 2024-02-17 23:57:58 -07:00
CONTRIBUTING Outdated
@ -94,1 +93,3 @@
using four-character-wide indentation steps.
Make sure lines never exceed 80 columns in width when using four-character
indentation steps. This helps contributors who do not have access to text
wrapping in their text editors or terminals.
trinity commented 2024-02-17 23:56:30 -07:00
Owner
Copy Link

"This ensures contributors with smaller viewports can continue to easily contribute while letting contributors with large screens use multiple editing panes side-by-side."

"This ensures contributors with smaller viewports can continue to easily contribute while letting contributors with large screens use multiple editing panes side-by-side."
emma marked this conversation as resolved
CONTRIBUTING Outdated
@ -102,2 +102,3 @@
guidelines:
$ git commit -m 'tool(1): <information>'
$ git commit -m 'tool(1): added feature x'
trinity commented 2024-02-17 23:57:44 -07:00
Owner
Copy Link

Should be present tense, as a git commit is less a historical note and more a description of how the operation is affecting the graph.

Should be present tense, as a git commit is less a historical note and more a description of how the operation *is affecting* the graph.
emma marked this conversation as resolved
CONTRIBUTING Outdated
@ -116,0 +126,4 @@
Commit messages should be written in the past tense.
[1] <http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/src/share/misc/style>
trinity commented 2024-02-17 23:54:20 -07:00
Owner
Copy Link

This reference should probably be closer to the ref if it's only cited once.

This reference should probably be closer to the ref if it's only cited once.
emma marked this conversation as resolved
emma requested review from trinity 2024-02-18 15:09:43 -07:00
emma added 1 commit 2024-02-18 15:09:44 -07:00
trinity approved these changes 2024-02-23 18:42:55 -07:00
trinity left a comment
Owner
Copy Link

Looks good.

Looks good.
CONTRIBUTING Outdated
@ -66,3 +66,3 @@
* notice:
*
* MIT License
* MIT Licenseutils
trinity commented 2024-02-23 18:42:02 -07:00
Owner
Copy Link

huh?

[huh?](https://yewtu.be/watch?v=rLYVFUP2wVs)
emma marked this conversation as resolved
emma added 1 commit 2024-02-23 23:20:26 -07:00
emma closed this pull request 2024-02-23 23:21:18 -07:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
silt
trinity
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
joke
you are silly!
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
emma nitori silt trinity
No Assignees emma
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonsai/harakit#52
No description provided.
Delete Branch "contributing-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?