swab(1) #73

trinity · 2024-02-24T03:25:03-07:00

trinity commented

2024-02-24 03:25:03 -07:00

Implements #22.

trinity added the

enhancement

label 2024-02-24 03:25:03 -07:00

trinity added 3 commits 2024-02-24 03:25:03 -07:00

swab(1): minimum viable program 3f0d95fe8f

swab(1): add argument parsing e788947fc4

swab.1: add swab(1) man page 1e041a52a2

trinity requested review from emma 2024-02-24 03:26:50 -07:00

emma approved these changes 2024-02-24 14:44:25 -07:00

emma left a comment

Looks really good!

Makefile

						
				@ -102,2 +102,4 @@

					$(CC) $(CFLAGS) -o $@ src/strcmp.c

				.PHONY: swab

				swab: build/bin/swab

emma commented

2024-02-24 14:42:00 -07:00

Don’t forget to add swab to the all target!

trinity marked this conversation as resolved

src/swab.rs Outdated

						
				@ -0,0 +1,72 @@

				use std::{

emma commented

2024-02-24 14:44:18 -07:00

Needs a copyright header :)

trinity marked this conversation as resolved

src/swab.rs Outdated

						
				@ -0,0 +51,4 @@

					buf.resize(wordsize, 0);

					loop {

						match input.read(&mut buf) {

emma commented

2024-02-24 14:42:46 -07:00

This seems cleaner to me, but it doesn’t really matter:

		match input.read(&mut buf) {
			Ok(0) => break ExitCode::from(EX_OK as u8),
			Ok(v)  => {
				if v == wordsize {
					let (left, right) = buf.split_at(v/2);
					if let Err(e) = output.write(&right)
							.and_then(|_| output.write(&left)) {
						break oserr(&argv[0], e)
					}
				} else {
					if let Err(e) = output.write(&buf[..v]) {
						break oserr(&argv[0], e)
					}
				}
			},
			Err(e) => {
				if e.kind() == ErrorKind::Interrupted && force { continue }
				else { break oserr(&argv[0], e) }
			},
		}

This seems cleaner to me, but it doesn’t really matter: ```rs match input.read(&mut buf) { Ok(0) => break ExitCode::from(EX_OK as u8), Ok(v) => { if v == wordsize { let (left, right) = buf.split_at(v/2); if let Err(e) = output.write(&right) .and_then(|_| output.write(&left)) { break oserr(&argv[0], e) } } else { if let Err(e) = output.write(&buf[..v]) { break oserr(&argv[0], e) } } }, Err(e) => { if e.kind() == ErrorKind::Interrupted && force { continue } else { break oserr(&argv[0], e) } }, } ```

trinity commented

2024-02-26 07:05:56 -07:00

I prefer my style of mostly using the match statement.

trinity marked this conversation as resolved

trinity added 2 commits 2024-02-26 17:04:47 -07:00

swab(1): add copyright notice bbac85daf8

Makefile: add swab(1) f14877118d

trinity requested review from emma 2024-02-27 04:06:02 -07:00

emma approved these changes 2024-02-28 00:10:04 -07:00

emma closed this pull request

2024-03-18 20:54:50 -06:00