bonsai/harakit
4
4
Fork 3
Code Issues 39 Pull Requests 3 Projects 1 Releases 36 Activity

swab(1) #73

Closed
trinity wants to merge 0 commits from swab into main
pull from: swab
merge into: bonsai:main
Conversation 2 Commits - Files Changed -
trinity commented 2024-02-24 03:25:03 -07:00
Owner
Copy Link

Implements #22.

Implements #22.
trinity added the
enhancement
 label 2024-02-24 03:25:03 -07:00
trinity added 3 commits 2024-02-24 03:25:03 -07:00
trinity requested review from emma 2024-02-24 03:26:50 -07:00
emma approved these changes 2024-02-24 14:44:25 -07:00
emma left a comment
Owner
Copy Link

Looks really good!

Looks really good!
Makefile
@ -102,2 +102,4 @@
$(CC) $(CFLAGS) -o $@ src/strcmp.c
.PHONY: swab
swab: build/bin/swab
emma commented 2024-02-24 14:42:00 -07:00
Owner
Copy Link

Don’t forget to add swab to the all target!

Don’t forget to add swab to the all target!
trinity marked this conversation as resolved
src/swab.rs Outdated
@ -0,0 +1,72 @@
use std::{
emma commented 2024-02-24 14:44:18 -07:00
Owner
Copy Link

Needs a copyright header :)

Needs a copyright header :)
trinity marked this conversation as resolved
src/swab.rs Outdated
@ -0,0 +51,4 @@
buf.resize(wordsize, 0);
loop {
match input.read(&mut buf) {
emma commented 2024-02-24 14:42:46 -07:00
Owner
Copy Link

This seems cleaner to me, but it doesn’t really matter:

		match input.read(&mut buf) {
			Ok(0) => break ExitCode::from(EX_OK as u8),
			Ok(v)  => {
				if v == wordsize {
					let (left, right) = buf.split_at(v/2);
					if let Err(e) = output.write(&right)
							.and_then(|_| output.write(&left)) {
						break oserr(&argv[0], e)
					}
				} else {
					if let Err(e) = output.write(&buf[..v]) {
						break oserr(&argv[0], e)
					}
				}
			},
			Err(e) => {
				if e.kind() == ErrorKind::Interrupted && force { continue }
				else { break oserr(&argv[0], e) }
			},
		}
This seems cleaner to me, but it doesn’t really matter: ```rs match input.read(&mut buf) { Ok(0) => break ExitCode::from(EX_OK as u8), Ok(v) => { if v == wordsize { let (left, right) = buf.split_at(v/2); if let Err(e) = output.write(&right) .and_then(|_| output.write(&left)) { break oserr(&argv[0], e) } } else { if let Err(e) = output.write(&buf[..v]) { break oserr(&argv[0], e) } } }, Err(e) => { if e.kind() == ErrorKind::Interrupted && force { continue } else { break oserr(&argv[0], e) } }, } ```
trinity commented 2024-02-26 07:05:56 -07:00
Author
Owner
Copy Link

I prefer my style of mostly using the match statement.

I prefer my style of mostly using the match statement.
trinity marked this conversation as resolved
trinity added 2 commits 2024-02-26 17:04:47 -07:00
trinity requested review from emma 2024-02-27 04:06:02 -07:00
emma approved these changes 2024-02-28 00:10:04 -07:00
emma closed this pull request 2024-03-18 20:54:50 -06:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
emma
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
joke
you are silly!
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
emma nitori silt trinity
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonsai/harakit#73
No description provided.
Delete Branch "swab"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?