bonsai/harakit
5
4
Fork 3
Code Issues 41 Pull Requests 7 Projects 1 Releases 30 Activity

Makefile: fixed manpage install location #97

Closed
emma wants to merge 0 commits from manpage-install into main
pull from: manpage-install
merge into: bonsai:main
Conversation 1 Commits - Files Changed -
emma commented 2024-04-25 12:43:01 -06:00
Owner
Copy Link
No description provided.
emma added the
bug
 label 2024-04-25 12:43:01 -06:00
emma self-assigned this 2024-04-25 12:43:01 -06:00
emma added 1 commit 2024-04-25 12:43:01 -06:00
emma requested review from trinity 2024-04-25 12:43:04 -06:00
emma added 1 commit 2024-04-25 12:44:25 -06:00
trinity approved these changes 2024-04-26 19:49:26 -06:00
trinity left a comment
Owner
Copy Link

Other than my boomer gripe it looks good.

Other than my boomer gripe it looks good.
Makefile
@ -17,6 +17,8 @@
DESTDIR ?= dist
PREFIX ?= /usr/local
MANDIR != [ $(PREFIX) = / ] && printf '/usr/share/man\n' \
trinity commented 2024-04-26 19:49:03 -06:00
Owner
Copy Link

Could we use [ as test? The left-bracket use is a code smell for me as it tends to be more error prone. This particular usage seems fine.

Could we use `[` as `test`? The left-bracket use is a code smell for me as it tends to be more error prone. This particular usage seems fine.
emma commented 2024-04-27 13:03:08 -06:00
Author
Owner
Copy Link

Merged.

Merged.
emma closed this pull request 2024-04-27 13:03:08 -06:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
trinity
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
joke

you are silly!

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
joke
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
emma
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: bonsai/harakit#97
No description provided.
Delete Branch "manpage-install"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?