bonsai/harakit
5
4
Fork 3
Code Issues 42 Pull Requests 5 Projects 1 Releases 34 Activity

scrut(1): changed return status 0 to EXIT_SUCCESS #98

Closed
emma wants to merge 0 commits from scrut-sysexits into main
pull from: scrut-sysexits
merge into: bonsai:main
Conversation 2 Commits - Files Changed -
emma commented 2024-04-25 16:48:19 -06:00
Owner
Copy Link

closes #78

closes #78
emma added the
enhancement
 label 2024-04-25 16:48:19 -06:00
emma added 1 commit 2024-04-25 16:48:19 -06:00
emma requested review from trinity 2024-04-25 16:48:23 -06:00
trinity added 3 commits 2024-04-26 19:36:00 -06:00
trinity added 1 commit 2024-04-26 19:38:29 -06:00
trinity commented 2024-04-26 19:45:47 -06:00
Owner
Copy Link

I added some small additional fixes to this branch.

  • You changed return 0 to return EXIT_SUCCESS, which was good, but return 1 was still present, so I changed it to return EXIT_FAILURE.
  • I updated the copyright header to include you and bump my contributions to 2023-2024.
  • At one point when working with <sysexits.h> some particularities with its inclusion were lost - I only include <sysexits.h>, which is technically non-portable, when the definitions being used aren't already present.

I also merged the branch main into this one; there were no conflicts. Please review my changes and let me know what you think. I would have made comments but they seemed small and unopinionated.

I added some small additional fixes to this branch. - You changed `return 0` to `return EXIT_SUCCESS`, which was good, but `return 1` was still present, so I changed it to `return EXIT_FAILURE`. - I updated the copyright header to include you and bump my contributions to 2023-2024. - At one point when working with `<sysexits.h>` some particularities with its inclusion were lost - I only include `<sysexits.h>`, which is technically non-portable, when the definitions being used aren't already present. I also merged the branch `main` into this one; there were no conflicts. Please review my changes and let me know what you think. I would have made comments but they seemed small and unopinionated.
trinity approved these changes 2024-04-26 19:46:49 -06:00
trinity closed this pull request 2024-04-27 11:24:45 -06:00
trinity commented 2024-04-27 11:25:11 -06:00
Owner
Copy Link

Merged.

Merged.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
trinity
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
joke

you are silly!

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
joke
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: bonsai/harakit#98
No description provided.
Delete Branch "scrut-sysexits"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?