dtb trinity
3 Followers · 4 Following
Repositories
4
 Projects Packages Public Activity Starred Repositories
3
trinity commented on pull request bonsai/harakit#142 2024-07-15 02:26:36 -06:00
Formatting

The opposite is true.

trinity commented on pull request bonsai/harakit#142 2024-07-15 02:26:36 -06:00
Formatting

This is write size. But dj(1) writes everything it reads.

trinity commented on pull request bonsai/harakit#142 2024-07-15 02:26:36 -06:00
Formatting

This sounds wack.

trinity commented on pull request bonsai/harakit#142 2024-07-15 02:02:57 -06:00
Formatting

This should stay that way because it's somewhat common practice among greybeards (I know many in the 9front community do it).

trinity commented on pull request bonsai/harakit#142 2024-07-15 02:01:28 -06:00
Formatting

It should be highlighted that the input buffer should be very large (e.g. 4M) to take advantage of modern hardware I/O speeds, and for most uses mm(1) is better.

trinity approved bonsai/harakit#143 2024-07-15 01:42:29 -06:00
mm(1): rewritten in Rust
trinity commented on pull request bonsai/harakit#143 2024-07-15 01:42:00 -06:00
mm(1): rewritten in Rust

Cleaner, shorter, nicer.

trinity commented on pull request bonsai/harakit#142 2024-07-13 00:44:10 -06:00
Formatting

This should be -1. While it is in reality 255, the negative is consistent with strcmp(3p) and may be useful on certain systems. Also, at some point retvals here should be more significant.

trinity commented on pull request bonsai/harakit#142 2024-07-13 00:44:10 -06:00
Formatting

if (!(argc < 0)) https://en.cppreference.com/w/c/language/operator_precedence

trinity commented on pull request bonsai/harakit#142 2024-07-13 00:44:10 -06:00
Formatting

C89 can't do 0b literals, which is why I used the more portable hex with a comment.

trinity commented on pull request bonsai/harakit#142 2024-07-13 00:44:10 -06:00
Formatting

Variables should be declared at the start of the scope; this is invalid C89.

trinity commented on pull request bonsai/harakit#142 2024-07-13 00:44:10 -06:00
Formatting

Say which ones you're using.

trinity commented on pull request bonsai/harakit#142 2024-07-13 00:44:10 -06:00
Formatting

This is so I can move to /^function/ to find its definition.

trinity commented on pull request bonsai/harakit#142 2024-07-13 00:44:10 -06:00
Formatting

This ternary should happen somewhere in main.

trinity commented on pull request bonsai/harakit#142 2024-07-13 00:44:10 -06:00
Formatting

Test if argc is zero before doing this.

trinity commented on pull request bonsai/harakit#142 2024-07-13 00:44:10 -06:00
Formatting

Which sysexits?

trinity commented on pull request bonsai/harakit#142 2024-07-13 00:44:10 -06:00
Formatting

if(!(argc > 0)). Also, this program should work when argc==0.

trinity suggested changes for bonsai/harakit#142 2024-07-13 00:44:10 -06:00
Formatting
trinity created pull request bonsai/harakit#141 2024-07-10 12:41:42 -06:00
WIP: utf(1)
trinity deleted branch swab from bonsai/harakit 2024-07-10 12:40:52 -06:00