dtb trinity
trinity pushed to main at trinity/src 2024-12-01 10:00:08 -07:00
ec36101d99 2024-12-01
trinity pushed to main at trinity/src 2024-11-11 11:44:04 -07:00
e55e0945a4 2024-11-11
trinity pushed to main at trinity/src 2024-10-02 19:49:43 -06:00
a60b3c7daf 2024-09-14
trinity commented on pull request bonsai/harakit#146 2024-09-29 20:47:28 -06:00
Replace scrut(1) with fileis(1)

I disagree with the form but can't help agreeing with the compilation benefits.

trinity commented on pull request bonsai/harakit#146 2024-09-25 22:18:16 -06:00
Replace scrut(1) with fileis(1)

I would rather have declarations precede assignments here. I understand assignment on declaration is idiomatic in Rust. Python, in fact, due to its type system, mandated it. But I've been forced to separate them (often) in C, and, having used both styles, prefer the separation for clarity of code.

trinity commented on pull request bonsai/harakit#146 2024-09-09 07:45:01 -06:00
Replace scrut(1) with fileis(1)

Line 59 happens when a file is non-existent, which means it's failed the test.

trinity commented on pull request bonsai/harakit#156 2024-09-09 07:38:47 -06:00
STYLE: make rules more granular and consistent, add examples

Maybe, "where possible"?

trinity commented on pull request bonsai/harakit#156 2024-09-09 07:37:44 -06:00
STYLE: make rules more granular and consistent, add examples

I fear this is impossible; dj(1), for instance, necessarily can't put an upward bound on read cycles.

trinity commented on pull request bonsai/harakit#156 2024-09-09 07:36:32 -06:00
STYLE: make rules more granular and consistent, add examples

This should just be default: (so, sed 34s:case ::); as-is this is a syntax error.

trinity commented on pull request bonsai/harakit#161 2024-09-09 07:34:07 -06:00
optimizations

From OpenBSD man 2 pledge:

     Passing NULL to promises or execpromises specifies to not change the
     current value.

It seems a number of these should be pledge("", "");.

trinity commented on pull request bonsai/harakit#102 2024-09-04 20:56:01 -06:00
Replace str(1) with stris(1)

This pull request is acceptable but the program needs a good name.

trinity closed pull request bonsai/harakit#93 2024-09-04 20:54:33 -06:00
peek(1)
trinity deleted branch peek from bonsai/harakit 2024-09-04 20:54:33 -06:00
trinity commented on pull request bonsai/harakit#93 2024-09-01 19:51:53 -06:00
peek(1)

Merged (via cherry-picking to avoid redundant commits).

trinity pushed to main at bonsai/harakit 2024-09-01 19:51:17 -06:00
87c9e29932 tests: bonsai/peek.mk
1037e32e6e peek(1): fix erroring on stdin/stdout redirection
5c70852890 peek.1: replace parens with square brackets
8ec18ccf75 peek(1): use stdbool.h
3bfdc62035 peek(1): better error on piping
Compare 21 commits »
trinity commented on pull request bonsai/harakit#102 2024-09-01 19:37:21 -06:00
Replace str(1) with stris(1)

I like sid(1) but don't love it.

trinity commented on pull request bonsai/harakit#149 2024-09-01 19:36:27 -06:00
README: fix vagueness

Good additions.

trinity commented on pull request bonsai/harakit#93 2024-09-01 19:31:50 -06:00
peek(1)

I requested (in private messages) silt's review because a number of changes were required last-minute to make testing work (peek -i </dev/null >/dev/null would fail).

trinity pushed to peek at bonsai/harakit 2024-09-01 09:24:25 -06:00
f7a8158347 tests: bonsai/peek.mk
e1145931a5 peek(1): fix erroring on stdin/stdout redirection
9005ffdaa7 Merge branch 'main' into peek
fbacfecce8 Merge branch 'linux-fix' (closes #158)
579ff65b67 tests: bonsai/npc.mk: drop redundant tab removal
Compare 180 commits »