I disagree with the form but can't help agreeing with the compilation benefits.
I would rather have declarations precede assignments here. I understand assignment on declaration is idiomatic in Rust. Python, in fact, due to its type system, mandated it. But I've been forced to separate them (often) in C, and, having used both styles, prefer the separation for clarity of code.
Line 59 happens when a file is non-existent, which means it's failed the test.
I fear this is impossible; dj(1), for instance, necessarily can't put an upward bound on read cycles.
This should just be default:
(so, sed 34s:case ::
); as-is this is a syntax error.
From OpenBSD man 2 pledge
:
Passing NULL to promises or execpromises specifies to not change the
current value.
It seems a number of these should be pledge("", "");
.
I requested (in private messages) silt's review because a number of changes were required last-minute to make testing work (peek -i </dev/null >/dev/null
would fail).