dtb trinity
trinity commented on pull request bonsai/harakit#142 2024-07-25 20:21:41 -06:00
Formatting

Examples of this would be good.

trinity commented on pull request bonsai/harakit#142 2024-07-25 20:21:41 -06:00
Formatting

the length of, or so

trinity commented on pull request bonsai/harakit#142 2024-07-25 20:21:41 -06:00
Formatting

That's intense. An example:

trinity commented on pull request bonsai/harakit#142 2024-07-25 20:21:41 -06:00
Formatting

Prepare to cast all fprintf(3p)s.

trinity commented on pull request bonsai/harakit#142 2024-07-25 20:21:41 -06:00
Formatting

Is this possible for analyzing arrays of strings?

trinity commented on pull request bonsai/harakit#142 2024-07-25 20:21:41 -06:00
Formatting

The compiler will filter this if down to one condition anyway. Why are there two here? argc==0 isn't a special case with regards to intcmp(1), except that the program_name fallback needs to be used.

trinity commented on pull request bonsai/harakit#142 2024-07-25 20:21:41 -06:00
Formatting

I'm reviewing this hastily because the Rust rewrite is a superior version anyway.

trinity commented on pull request bonsai/harakit#142 2024-07-25 20:21:41 -06:00
Formatting

Why move this? It was more efficient before this changed. Anyone curious about the self-explanatory program_name can just grep for it in the file.

trinity commented on pull request bonsai/harakit#142 2024-07-25 20:21:41 -06:00
Formatting

The previous version of this wasn't pretty, but adopting an if (argc > 0) { program_name = argv[0]; ... like dj(1) used to have would be consistent (these are both utilities that can run without arguments, but which take options) and efficient.

trinity commented on pull request bonsai/harakit#142 2024-07-25 20:21:41 -06:00
Formatting

This should be program_name or, ideally, merged back into the if (argc < 3) check from whence it came.

trinity suggested changes for bonsai/harakit#142 2024-07-25 20:21:41 -06:00
Formatting
trinity commented on pull request bonsai/harakit#142 2024-07-25 20:19:42 -06:00
Formatting

I regard the harakit as art as well as code. Each utility should be simple, but also the best at what it does ("do one thing well"). Lost cycles add up. I don't care how small the issue is, I…

trinity commented on pull request bonsai/harakit#142 2024-07-25 19:59:15 -06:00
Formatting

I can't add a second comment on the same line but program_name should be set here to argv[0], which would be consistent with my suggested change to mm(1) and how dj(1) was before this patchset.

trinity commented on pull request bonsai/harakit#142 2024-07-25 19:49:00 -06:00
Formatting

I didn't see it but this case is already covered on L189; if argc > 0 { program_name = argv[0]; ...

trinity pushed to simexec at trinity/overgrown 2024-07-24 23:45:24 -06:00
2337cedd77 run.1: rename man page from simexec.1
trinity pushed to simexec at trinity/overgrown 2024-07-24 23:40:05 -06:00
e0f9641e93 run(1) works
f7e0cb5c14 simexec(1): rename to run(1)
653576b35d simexec(1): Merge in pschdir(1) functionality
87845ba5bd Merge branch 'pschdir' into simexec
427e1b9d36 simexec(1): non-functional Rust rewrite
Compare 9 commits »
trinity pushed to overgrown at trinity/overgrown 2024-07-24 10:50:14 -06:00
1ca3dadc99 README: overgrown
trinity pushed to overgrown at trinity/overgrown 2024-07-23 21:15:15 -06:00
7b2310f8f4 Merge branch 'pschdir' into overgrown
e34e4fad3f pschdir(1): rewrite in Rust
Compare 2 commits »
trinity pushed to pschdir at trinity/overgrown 2024-07-23 21:14:58 -06:00
e34e4fad3f pschdir(1): rewrite in Rust
trinity pushed to overgrown at trinity/overgrown 2024-07-23 20:14:53 -06:00
8a7cb24500 Merge branch 'argued' into overgrown
fa5e320b41 argued(1): re-write in Rust
Compare 2 commits »