bonsai/harakit
5
4
Fork 3
Code Issues 43 Pull Requests 3 Projects 1 Releases 36 Activity

dj(1) segfault fix #134

Closed
trinity wants to merge 0 commits from dj into main
pull from: dj
merge into: :main
Conversation 11 Commits - Files Changed -
trinity commented 2024-07-03 14:24:19 -06:00
Owner
Copy Link
Copy Source
+ dj(1) is now littered with assertions for future bug report help + fixes #112 + "hard" skips and seeks (without lseek(3p)) are reported in the diagnostics + considerable refactoring + updated docs
trinity added the bug label 2024-07-03 14:24:19 -06:00
trinity added 2 commits 2024-07-03 14:24:20 -06:00
dj(1): fix option parsing regression 064abb82a6
dj(1): add a ton of assertions, fix if statement, fix io[i] mixups 1cf67af281
trinity added 2 commits 2024-07-03 14:50:58 -06:00
dj(1): remove Io_bufalloc 76252305f9
dj(1): remove debugging vestige, reflow output into printio aff658d611
trinity commented 2024-07-03 14:53:05 -06:00
Author
Owner
Copy Link
Copy Source

@emma could you verify #112 is fixed on this branch?

@emma could you verify #112 is fixed on this branch?
trinity requested review from emma 2024-07-03 14:53:16 -06:00
trinity requested review from silt 2024-07-03 14:53:16 -06:00
trinity marked the pull request as ready for review 2024-07-03 14:53:24 -06:00
emma approved these changes 2024-07-03 15:36:16 -06:00
Dismissed
trinity added 5 commits 2024-07-03 16:13:29 -06:00
dj(1): fix potential skip/seek bug in non-std io 6548a448c7
dj(1): prefix getopt optstring with : 3897f44cf8
dj(1): remove unnecessary stderr checks 66ca4b9a12
dj(1): Refactor out Io_fdseek entirely 944feef434
dj.1: clarify skip/seek behavior with regards to statistics output 7fe122ac3b
trinity requested review from emma 2024-07-03 16:14:37 -06:00
emma requested changes 2024-07-03 16:22:19 -06:00
Dismissed
docs/dj.1 Outdated
@@ -36,3 +36,3 @@
When seeking or skipping to a byte, writing or reading starts at the byte
immediately subsequent to the specified byte.
immediately subsequent to the specified byte. Seeks and skips aren\(cqt counted
emma commented 2024-07-03 16:21:32 -06:00
Owner
Copy Link
Copy Source

Isn’t this not the case anymore? I thought we write at the byte specified, now.

Isn’t this not the case anymore? I thought we write at the byte specified, now.
trinity marked this conversation as resolved
trinity added 3 commits 2024-07-03 18:31:39 -06:00
dj(1): iron out Io_bufxapp f4b97be1f1
dj(1): fix segfault when bses are mismatched 2167f35f58
dj.1: elaborate on skip/seek behavior, provide another example adda0d9580
trinity requested review from emma 2024-07-03 18:31:57 -06:00
trinity added 1 commit 2024-07-03 18:44:54 -06:00
dj(1): clean up some stray ends 3e1735f778
trinity added 2 commits 2024-07-03 19:07:44 -06:00
dj(1): remove Io_bufxfer b74160fa4e
dj(1): remove Io_bufrpad 2b593559af
trinity added 1 commit 2024-07-03 19:22:51 -06:00
dj(1): remove Io_fdopen 5b1d4fef88
trinity added 1 commit 2024-07-03 20:52:52 -06:00
dj(1): only include sysexits if they aren't defined cc64561388
trinity added 5 commits 2024-07-04 19:46:02 -06:00
dj(1): use the retvals of Io_read and Io_write 4004a4a006
dj(1): move prec and rec adjustment into Io_read f49a2d2eb8
dj(1): make printio fprintio fc0d9e374b
dj(1): make Io_write handle prec and rec f8c0e0570c
dj(1): move open(2) flags, remove unnecessary comments 8c33f0116c
trinity added 7 commits 2024-07-04 21:32:29 -06:00
dj(1): add a variable for skipping in the main loop fe175cab19
dj(1): no more pointer arithmetic 1fab60d779
dj(1): more work adapting hard skipping to the main loop 9f420131ee
dj(1): (broken) move hard skipping to the main loop 906eb92f5a
dj(1): fix inaccurate statistics after Io_read and Io_write 9e8b82c4bb
dj.1: update man page to match behavior 571796fe0d
dj(1): statistics now track hard seeks 6ed7089b25
trinity added 1 commit 2024-07-05 08:06:52 -06:00
dj(1): fix some type issues abfe7046e7
trinity commented 2024-07-05 08:17:37 -06:00
Author
Owner
Copy Link
Copy Source

I think this is the best dj(1) can be, at least until we spot another bug. #94 will let us move out that parse() routine which will be nice.

I'm happy with the code size, especially relative to functionality which is much improved. Many of the little nits have been picked.

I think this is the best dj(1) can be, at least until we spot another bug. #94 will let us move out that parse() routine which will be nice. I'm happy with the code size, especially relative to functionality which is much improved. Many of the little nits have been picked.
emma commented 2024-07-07 17:50:17 -06:00
Owner
Copy Link
Copy Source
$ build/bin/dj -o /dev/full
meow meow meow
build/bin/dj: Partial read:
	0100150010015-2

No error message to alert the user that the device has no storage left. Please handle the error in writing to an output.

``` $ build/bin/dj -o /dev/full meow meow meow build/bin/dj: Partial read: 0100150010015-2 ``` No error message to alert the user that the device has no storage left. Please handle the error in writing to an output.
trinity commented 2024-07-07 18:07:21 -06:00
Author
Owner
Copy Link
Copy Source

Please comment with the output with -H.

On OpenBSD, write(2) doesn't error (by returning -1) on /dev/full - writing "meow\n" to /dev/full apparently succeeds, returning 5 (the expected number of bytes written).

dd(1) on OpenBSD exhibits the same behavior:

# printf 'meow\n' | dd of=/dev/full
0+1 records in
0+1 records out
5 bytes transferred in 0.000 secs (40922 bytes/sec)

I had to $ cat </dev/full to realize the pseudodevice doesn't exist on OpenBSD. It looks like the write succeeded on your system, too? What's your $ uname -a?

Please comment with the output with -H. On OpenBSD, write(2) doesn't error (by returning -1) on /dev/full - writing "meow\n" to /dev/full apparently succeeds, returning 5 (the expected number of bytes written). dd(1) on OpenBSD exhibits the same behavior: ``` # printf 'meow\n' | dd of=/dev/full 0+1 records in 0+1 records out 5 bytes transferred in 0.000 secs (40922 bytes/sec) ``` I had to `$ cat </dev/full` to realize the pseudodevice doesn't exist on OpenBSD. It looks like the write succeeded on your system, too? What's your `$ uname -a`?
trinity added 1 commit 2024-07-07 18:15:08 -06:00
dj(1): Io_write: don't add to bufuse bab3cdd90e
emma commented 2024-07-07 18:15:12 -06:00
Owner
Copy Link
Copy Source
$ uname -a             
Linux noire-carnation 6.9.7-artix1-1 #1 SMP PREEMPT_DYNAMIC Fri, 28 Jun 2024 18:11:28 +0000 x86_64 GNU/Linux
$ build/bin/dj -Ho /dev/full
meow meowm oew
build/bin/dj: Partial read:
	0+1 > 0+0; 15 > 0
0+1 > 0+0; 15 > -2
``` $ uname -a Linux noire-carnation 6.9.7-artix1-1 #1 SMP PREEMPT_DYNAMIC Fri, 28 Jun 2024 18:11:28 +0000 x86_64 GNU/Linux $ build/bin/dj -Ho /dev/full meow meowm oew build/bin/dj: Partial read: 0+1 > 0+0; 15 > 0 0+1 > 0+0; 15 > -2 ```
trinity commented 2024-07-07 18:16:24 -06:00
Author
Owner
Copy Link
Copy Source

Along these lines I did notice a bug in the write functionality that is now fixed. Judging from your dj(1) statistics it wasn't, but you may want to try again anyway.

Along these lines I did notice a bug in the write functionality that is now fixed. Judging from your dj(1) statistics it wasn't, but you may want to try again anyway.
trinity added 1 commit 2024-07-07 20:34:13 -06:00
dj(1): error reporting more of the time 691e94c0c1
trinity commented 2024-07-07 21:14:18 -06:00
Author
Owner
Copy Link
Copy Source

Give it another whirl.

Give it another whirl.
trinity added 1 commit 2024-07-07 21:15:19 -06:00
dj(1): fix retvals 5d5a6d2172
emma approved these changes 2024-07-07 23:41:21 -06:00
trinity commented 2024-07-08 11:21:35 -06:00
Author
Owner
Copy Link
Copy Source

Merged.

Merged.
trinity closed this pull request 2024-07-08 11:24:20 -06:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
silt
emma
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 joke
you are silly!
 question
More information is needed
 wontfix
This won't be fixed
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
emma (Emma Tebibyte) nitori silt (silt!) soup (Soup For My Family) trinity (dtb)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonsai/harakit#134