bonsai/harakit
5
4
Fork 3
Code Issues 44 Pull Requests 9 Projects 1 Releases 27 Activity

dj(1): fix yet another stdin skipping bug #138

Closed
trinity wants to merge 0 commits from dj into main
pull from: dj
merge into: bonsai:main
Conversation 1 Commits - Files Changed -
trinity commented 2024-07-09 04:57:50 +00:00
Owner
Copy Link

Introduced in #134, one juicy infiniskip that is rectified with basic subtraction. I noticed this while working on #96.

Once you see the fix, the bug is easy to spot. I introduced another bug in the process of fixing the first but the io->bufuse <= io->bs assertion in Io_read saved the day.

Introduced in #134, one juicy infiniskip that is rectified with basic subtraction. I noticed this while working on #96. Once you see the fix, the bug is easy to spot. I introduced another bug in the process of fixing the first but the `io->bufuse <= io->bs` assertion in `Io_read` saved the day.
trinity added the
bug
 label 2024-07-09 04:57:50 +00:00
trinity added 2 commits 2024-07-09 04:57:50 +00:00
trinity requested review from emma 2024-07-09 04:57:59 +00:00
emma added a new dependency 2024-07-12 21:34:18 +00:00
#142 Formatting
emma approved these changes 2024-07-12 21:34:36 +00:00
trinity commented 2024-07-15 08:36:34 +00:00
Author
Owner
Copy Link

Merged.

Merged.
trinity closed this pull request 2024-07-15 08:37:00 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
emma
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
joke

you are silly!

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
joke
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#142 Formatting
bonsai/harakit
Reference: bonsai/harakit#138
No description provided.
Delete Branch "dj"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?